2017-01-05 18:17 GMT+03:00 Elias M. Mariani <marianiel...@gmail.com>: > Hi Vadim, > First, thanks for your comments, they where really helpful in > understanding some of my mistakes around the Ports System. > I have another question, this is related to "ld", LXQt uses the > "-Bsymbolic-functions" option, wich is not documented on the GNU LD > 2.17 man page in OpenBSD-Current. Is there a workaround for this or I > should wait for and upgrade on ld ? > I tried to look on the ports files for any mention of > "symbolic-functions" and around the internet but nothing came up about > OpenBSD support of the option.
The -Bsymbolic-functions not supported by current OpenBSD linker, only -Bsymbolic is. So instead of hardcoding -Bsymbolic-functions usage, the LXQt build system should be patched to enable such only when supported. If it'll be too hard for you, just patch -Bsymbolic-functions (or -Wl,-Bsymbolic-functions - I hope LXQt uses the latter) out from compiler flags list and move on. > 2016-12-24 17:01 GMT-03:00 Vadim Zhukov <persg...@gmail.com>: >> 2016-12-24 21:46 GMT+03:00 Elias M. Mariani <marianiel...@gmail.com>: >>> Hello! >>> I'm Elias M. Mariani from Argentina, trying to port LXQt to OpenBSD: >>> https://github.com/21-OSD/LXQt-OpenBSD-port >>> >>> This is just a heads-up for other porters working or wanting to work >>> in the LXQt Port. >> >> Cool! >> >>> About current work: >>> - I just started two days ago, some packages seems to just work, >>> others needs minor patches, in example: >>> No wordexp -> Changed for glob. >>> - Makefiles not clean, i'm just trying to make the packages work, >>> cleaning will come later. >>> - Status of each package in the github README.md file. >> >> Sounds like a serious work. :) >> >>> Thats all, this is my first time porting to OpenBSD, advices, >>> warnings, comments and help is always welcome. >> >> First of all, if it's possible, could the work happen in openbsd-wip >> ports tree https://github.com/jasperla/openbsd-wip/ ? This would make >> it easier to review and tweak. >> >> Now a few comments. Please note that I didn't do the deep review, >> that's only a brief overview: >> >> 1. Why the need for lxqt.port.mk? >> >> 2. Use the "?=" or "+=" instead of "=" in Makefile.inc (and >> lxqt.port.mk, if you really need it). For example, this would make >> Makefile.inc not overwrite CATEGORIES but append to it instead. >> >> 3. Please add license marker to PERMIT_* line, mentioning licensing >> rules. Also, no need to duplicate this line in Makefiles when you have >> such line in Makefile.inc. >> >> 4. In pavucontrol-qt and others: "MODULES = x11/qt5 devel/cmake >> devel/qmake", - is it real? It's ought to be either devel/qmake or >> devel/cmake, depending on the build mechanism being used. >> >> 5. You likely noticed this, but still: "CXXFLAGS = >> -I/usr/local/include/X11/qt5/QtCore/5.5.1/QtCore >> -I/usr/local/include/X11/qt5/QtGui/5.5.1/QtGui" hardcodes paths. It >> looks like more a configure step error, something is wrong in >> include_directories() call. >> >> 6. devel/cmake in MODULES adds BUILD_DEPENDS on cmake automatically. >> >> 7. Long lines better be split, when possible. E.g., please, write either: >> >> CONFIGURE_ARGS = -Dfoo \ >> -Dbar \ >> -Dbuz >> >> or >> >> CONFIGURE_ARGS = -Dfoo >> CONFIGURE_ARGS += -Dbar >> CONFIGURE_ARGS += -Dbuz >> >> The general rule is 80-chars margin. >> >> 8. When you think the particular port is more or less ready, run >> portcheck in it. >> >> 9. COMMENT should not start from the capital letter or an article, >> unless the capital letter is due to being part of name. >> >> 10. In liblxqt, are you sure "-z __cxa_atexit" does something at all? >> The ld seems ignoring it, according to manual page. -- WBR, Vadim Zhukov
