There is an annoying non-deterministic crash present since at least 0.32
that occurs when ag is given an absolute path as root of the tree to search:

$ for f in $(jot 10); do ag pledge /usr/src/bin/pax >/dev/null; done
Segmentation fault (core dumped)
Segmentation fault (core dumped)
Segmentation fault (core dumped)
Segmentation fault (core dumped)
$

This was fixed nicely in a recent pull request:
https://github.com/ggreer/the_silver_searcher/pull/1040
The raw diff is here:
https://github.com/aswild/the_silver_searcher/commit/18df57f04ca20e70ed02a6ebc0b2f7bdc841c144.patch

The backtrace looks like this:
#0  strlen () at /usr/src/lib/libc/arch/amd64/string/strlen.S:124
#1  0x0000120160948734 in __vfprintf (fp=0x7f7ffffe1e90, fmt0=0x11fe70c0dd12 
"%s/%s", ap=Variable "ap" is not available.
)
    at /usr/src/lib/libc/stdio/vfprintf.c:891
#2  0x00001201609047bc in *_libc_vasprintf (str=0x7f7ffffe2040, 
fmt=0x11fe70c0dd12 "%s/%s", ap=0x7f7ffffe1f50)
    at /usr/src/lib/libc/stdio/vasprintf.c:40
#3  0x000011fe70b08192 in search_file_worker () from /usr/local/bin/ag
#4  0x000011fe70b00b70 in ?? () from /usr/local/bin/ag
#5  0x000011fe70b015cb in filename_filter () from /usr/local/bin/ag
...

Here's a diff with the revision bump plus a tarball with the four patches.

ok to commit this until a new release is cut?

Index: Makefile
===================================================================
RCS file: /var/cvs/ports/textproc/the_silver_searcher/Makefile,v
retrieving revision 1.23
diff -u -p -r1.23 Makefile
--- Makefile    15 Dec 2016 14:16:38 -0000      1.23
+++ Makefile    3 Jan 2017 21:26:40 -0000
@@ -7,6 +7,7 @@ CATEGORIES =    textproc
 
 HOMEPAGE =     https://github.com/ggreer/the_silver_searcher
 MAINTAINER =   Florian Stinglmayr <flor...@n0la.org>
+REVISION =     0
 
 # Apache 2.0
 PERMIT_PACKAGE_CDROM = Yes

Attachment: the_silver_searcher-1.0.2p0.tar.gz
Description: application/tar-gz

Reply via email to