On 2017/01/03 16:37, Lukasz Komsta wrote: > Dear All, > > This is my first attempt to create an OpenBSD port. > > I am the author of CWStudio. The newly released 0.9.5 version is fully > functional under OpenBSD (with simply configure and make on source), > carefully tested, and needs only ncurses and wxwidgets. Therefore this > is a simple port without any patches or advanced features. > > CWStudio is fast, computationally efficient and po rtable generator > of various CW signals for telegraphy training purposes. Besides > efficiency and port ability, it is designed to simulate as much as > possible a real air listening. > > http://cwstudio.sourceforge.net/ > > I would greatly appreciate if someone could test it and eventually > commit to ports tree. > > With best regards, > > Lukasz
Nice. I have a couple of minor tweaks (mostly just using standard makefile
ordering), diff below and new tar.gz attached, but otherwise this is looking
pretty good ports-wise.
Something I noticed about operation though, cwcurses and cwwx create
files named "x86_64-unknown-openbsd6.0" / "wx-x86_64-unknown-openbsd6.0",
and cwcli creates .txt and .wav files named with the "hex version of the
current time since epoch". They're created in the current directory which
is a bit unexpected, what do you think about using something like mkstemp(3)
or at least mkdtemp(3) so these can be in an safer location?
diff --git a/Makefile b/Makefile
index eb81402..969bca3 100644
--- a/Makefile
+++ b/Makefile
@@ -11,10 +11,6 @@ MAINTAINER = Lukasz Komsta
<lu...@users.sourceforge.net>
# GPLv3+
PERMIT_PACKAGE_CDROM = Yes
-PERMIT_PACKAGE_FTP = Yes
-
-PKG_ARCH = *
-CONFIGURE_STYLE = gnu
WANTLIB += ncursesw pthread sndio
WANTLIB += c m ossaudio stdc++
@@ -22,7 +18,9 @@ WANTLIB += wx_base wx_base_net wx_base_odbc wx_base_xml
wx_gtk2_adv
WANTLIB += wx_gtk2_aui wx_gtk2_core wx_gtk2_dbgrid wx_gtk2_html
WANTLIB += wx_gtk2_qa wx_gtk2_richtext wx_gtk2_xrc
-LIB_DEPENDS = x11/wxWidgets
MASTER_SITES = ${MASTER_SITE_SOURCEFORGE:=cwstudio/}
+CONFIGURE_STYLE = gnu
+LIB_DEPENDS = x11/wxWidgets
+
.include <bsd.port.mk>
diff --git a/pkg/DESCR b/pkg/DESCR
index 0d000fb..1194b8a 100644
--- a/pkg/DESCR
+++ b/pkg/DESCR
@@ -1,4 +1,4 @@
-CWStudio is fast, computationally efficient and po rtable generator
+CWStudio is fast, computationally efficient and portable generator
of various CW signals for telegraphy training purposes. Besides
-efficiency and port ability, it is designed to simulate as much as
+efficiency and portability, it is designed to simulate as much as
possible a real air listening.
cwstudio.tgz
Description: application/tar-gz
