On Thu, Dec 15, 2016 at 01:05:10PM -0800, Jeremy Evans wrote: > On 11/01 04:53, Jeremy Evans wrote: > > On 10/31 07:57, Pierre-Emmanuel Andr? wrote: > > > On Mon, Oct 31, 2016 at 09:53:24AM -0700, Jeremy Evans wrote: > > > > This updates pea@'s earlier diff that targeted 9.6.0 to work with > > > > 9.6.1, and modifies it to separate pg_upgrade into a separate > > > > subpackage. The pg_upgrade subpackage depends on a new port > > > > containing the previous PostgreSQL major version. > > > > > > > > The new port is databases/postgresql-previous, and it installs > > > > into /usr/local/{bin,include,lib,share}/postgresql-9.5 directories. > > > > We could obviously use subdirectories in databases/postgresql, but > > > > that creates more ports churn. I didn't use subpackages for > > > > postgresql-previous, merging the client/server/contrib packages > > > > and dropping the docs and plpython packages. I also dropped the > > > > rc script and README. I suppose we could add back the rc script > > > > if there are users that really want to run the previous version > > > > in production and not just use it for pg_upgrade. > > > > > > > > This updates the postgresql-server README to mention the use of > > > > pg_upgrade as a possible upgrade option. Basically, instead of > > > > dumping before upgrade and reloading after, you do: > > > > > > > > pg_upgrade -b /usr/local/bin/postgresql-9.5/ \ > > > > -B /usr/local/bin -U postgres \ > > > > -d /var/postgresql/data.old/ -D /var/postgresql/data > > > > > > > > after stopping the old server and before starting the new server. > > > > > > > > Briefly tested with a small (~400MB) database on amd64, no problems > > > > noticed. > > > > > > > > Before this can be committed, we need to test everything that depends > > > > on PostgreSQL and make sure it still works with 9.6.1, or have working > > > > diffs that can be committed shortly after the upgrade to 9.6.1. I hope > > > > to start that work shortly. > > > > > > > > Thoughts? > > > > > > > > > > Hi, > > > > > > Thanks for your diff. I will look at it asap. > > > For PostgreSQL 9.6, ajacoutot@ ran a bulk and it breaks: > > > databases/postgresql-plv8, databases/pg_statsinfo, databases/skytools, > > > databases/postgresql-pllua > > > > Here's a diff that allows all 4 to build. No run time tests yet. > > pea@ has OKed these changes, so unless I hear objections, I will be > importing postgresql-previous, upgrading postgresql to 9.6.1, > and committing the fixes to these four ports. If anyone else wants to > review and OK, that would be great.
I've re-read all this portswise, and it all makes fully sense to me. Thanks for working on that :) ok for me. Landry