Taylor Stearns <t...@tstearns.com> writes: > On Tue, Nov 15, 2016 at 06:56:59PM +0100, Rafael Sadowski wrote: >> On Mon Nov 14, 2016 at 03:54:30PM -0500, Taylor Stearns wrote: >> > On Fri, Nov 04, 2016 at 05:52:49PM -0400, Taylor Stearns wrote: >> > > On Thu, Jun 16, 2016 at 07:28:43PM -0400, Taylor Stearns wrote: >> > > > A small but very handy Perl script that I use myself frequently, so >> > > > made a port of >> > > > it. Upstream is https://github.com/philovivero/distribution >> > > > Looking for feedback or Ok. Thanks! >> > > > >> > > > $ cat distribution/pkg/DESCR >> > > > Short, simple, direct scripts for creating character-based graphs in a >> > > > command >> > > > terminal. >> > > > >> > > > It was originally for generating histograms (a distribution of the >> > > > frequency of >> > > > input tokens) but it has since been expanded to generate time-series >> > > > graphs (or, >> > > > in fact, graphs with any arbitrary "x-axis") as well. >> > > > >> > > >> > > Attached is an update to version 1.3 of 'textproc/distribution'. Tests >> > > are now enabled in the Makefile, and a few bugs fixed upstream. Any >> > > takers? I find that this little utility is one of the first things I >> > > install on a new system. >> > > >> > > -Taylor >> > >> > Hi all, can anybody provide feedback on this port or commit it? >> > >> >> Only runtime tests with some examples from `distribution --help`. The >> port looks also good to me. >> >> Kind regards, >> >> Rafael Sadowski >> > > Thanks Rafael. > > Is somebody available to commit this?
The port looks fine, I only tweaked the Makefile order to match Makefile.template, and shortened DESCR. "Short, simple, direct scripts..." doesn't make much sense when you're only shipping one script, also I don't think that mentioning how the script evolved over time matters here. I hope you agree with me here. The script uses #!/usr/bin/env perl, maybe this should be set to a fixed path but I do not have a strong opinion on the matter. To import this I'd need a review from another developer.
distribution.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
