On 2016/11/22 04:40, Jeremie Courreges-Anglas wrote: > > # lftp needs add_history_time() > > LIB_DEPENDS= devel/libidn \ > > devel/readline>=6.1p2 \ > > + > > +RUN_DEPENDS= devel/gettext > > I do not understand this. gettext could be part of LIB_DEPENDS, but why > would it be a RUN_DEPENDS? > > Even if lftp directly uses gettext, it seems that the preferred approach > is not to explicitely add it to LIB_DEPENDS, as libidn already brings > it.
Personally I prefer listing as a LIB_DEPENDS if it's known that a port uses it directly, it reduces the fallout if a well-used dependency is dropped later (like with curl/libidn). But I know for sure that opinions vary here :-) > > +BUILD_DEPENDS = devel/gettext-tools > > I see that there are tests for these tools at configure time, however > they don't seem to be strictly needed to build a proper package. No > objection if you want to keep this in BUILD_DEPENDS, if you think it > might prevent failures in bulks one day. Simple test: make configure with gettext-tools installed, pkg_delete gettext-tools, see if it still builds+packages. > > MASTER_SITES= https://lftp.yar.ru/ftp/ > > There is a problem with MASTER_SITES and redirections here. > > ritchie /usr/ports/net/lftp$ ftp https://lftp.yar.ru/ftp/lftp-4.7.4.tar.gz > Trying 213.187.99.145... > Requesting https://lftp.yar.ru/ftp/lftp-4.7.4.tar.gz > Redirected to https://lftp.tech/ftp/lftp-4.7.4.tar.gz > Trying 213.187.99.145... > Requesting https://lftp.tech/ftp/lftp-4.7.4.tar.gz > Redirected to https://lftp.tech/get.html > Trying 213.187.99.145... > Requesting https://lftp.tech/get.html > 100% |********[...]***************| 10156 00:00 > 10156 bytes received in 0.02 seconds (399.32 KB/s) > ritchie /usr/ports/net/lftp$ ftp http://lftp.tech/ftp/lftp-4.7.4.tar.gz > Trying 213.187.99.145... > Requesting http://lftp.tech/ftp/lftp-4.7.4.tar.gz > Redirected to http://lftp.tech/get.html > Trying 213.187.99.145... > Requesting http://lftp.tech/get.html > 100% |********[...]***************| 10156 00:00 > 10156 bytes received in 0.02 seconds (412.92 KB/s) > > Did you use ''make fetch'' to grab the tarball? Oh "nice", it looks like they redirect by default, but skip the redirection if it's curl or wget. > -MASTER_SITES= https://lftp.yar.ru/ftp/ > +MASTER_SITES= https://lftp.yar.ru/ftp/ \ > + ftp://ftp.st.ryukoku.ac.jp/pub/network/ftp/lftp/ Could you s/ftp/http/ (or add http first) please?
