On Tue, Nov 08, 2016 at 03:22:15PM +0000, Stuart Henderson wrote: > I've tried updating to git head and same problem.
I also saw the "TypeError: expected string or buffer" error message. The problem is in the installed ~/.urlwatch/hooks.py file: some examples aren't commented, and there is a problem somewhere: a "match" that shouldn't, and it breaks with cryptic python exception. So just keeping what I need in the file solves the problem for me. > Also one or two times > since the update I've seen what looks like a hang where it sits in > state:thrsleep with no activity apparent in ktrace. I personnally didn't see it. > It's a bit awkward since the database and config has changed completely. > But unless anyone has ideas of what might be wrong I think it might be a > good idea to revert www/urlwatch and add a new urlwatch2 port for those > that want it, what does anyone else think? As the switch from urlwatch to urlwatch2 could take lot of time for a complete transition, it could be a good solution :) In my case, I already switched, so please at least add a new urlwatch2. Thanks. -- Sebastien Marie > > > On 2016/11/01 15:57, Stuart Henderson wrote: > > On 2016/11/01 08:20, Robert Peichaer wrote: > > > CVSROOT: /cvs > > > Module name: ports > > > Changes by: r...@cvs.openbsd.org 2016/11/01 08:20:15 > > > > > > Modified files: > > > www/urlwatch : Makefile distinfo > > > www/urlwatch/pkg: PLIST > > > Removed files: > > > www/urlwatch/patches: patch-lib_urlwatch_html2txt_py > > > > > > Log message: > > > Update www/urlwatch to version 2. > > > > > > This is a major update for urlwatch which is now a python3 program. > > > Consider looking at the README.md at https://github.com/thp/urlwatch > > > if you are migrating from version 1. > > > > > > Noteable changes: > > > - the urls file is now in PyYaml format and will be auto-convertert > > > - watching ftp:// URLs needs a workaround like: > > > kind: shell > > > command: curl ftp://url/path/ > > > - custom hooks are different and need rewriting > > > > > > Feedback from and OK sthen@ aja@ > > > > > > > It was working when I first tried, but now command execution is resulting > > in errors like this, > > > > --------------------------------------------------------------------------- > > ERROR: curl -s ftp://ftp.astron.com/pub/file/ > > --------------------------------------------------------------------------- > > Traceback (most recent call last): > > File "/usr/local/lib/python3.4/site-packages/urlwatch/handler.py", line > > 69, in process > > data = FilterBase.auto_process(self, data) > > File "/usr/local/lib/python3.4/site-packages/urlwatch/filters.py", line > > 73, in auto_process > > if filter_instance.match(): > > File "/usr/local/lib/python3.4/site-packages/urlwatch/filters.py", line > > 115, in match > > result = all(v.match(d.get(k, None)) for k, v in self.MATCH.items()) > > File "/usr/local/lib/python3.4/site-packages/urlwatch/filters.py", line > > 115, in <genexpr> > > result = all(v.match(d.get(k, None)) for k, v in self.MATCH.items()) > > TypeError: expected string or buffer > > --------------------------------------------------------------------------- > > > > With 'urlwatch -v', > > > > 2016-11-01 15:30:21,996 handler INFO: Processing: <shell command='curl -s > > ftp://ftp.astron.com/pub/file/'> > > 2016-11-01 15:30:23,553 filters DEBUG: Matching <hooks.CustomMatchUrlFilter > > object at 0x8de58cf6a58> with <shell command='curl -s > > ftp://ftp.astron.com/pub/file/'> result: False > > 2016-11-01 15:30:23,553 urlwatch DEBUG: Job finished: <shell command='curl > > -s ftp://ftp.astron.com/pub/file/'> > > 2016-11-01 15:30:23,554 handler DEBUG: Got exception while processing > > <shell command='curl -s ftp://ftp.astron.com/pub/file/'>: expected string > > or buffer > > > > Does anyone have an idea what might be wrong? > > > -- Sebastien Marie
