Ray Lai <r...@raylai.com> writes: > On 10/23/16 18:53, Ray Lai wrote: >> Based on Carlos Alberto Pereira Gomes's work: >> https://marc.info/?l=openbsd-ports&m=105265115901089&w=2 >> >> DESCR: >> noweb is designed to meet the needs of literate programmers while >> remaining as simple as possible. Its primary advantages are simplicity, >> extensibility, and language-independence—especially noticeable >> when compared with other literate-programming tools. noweb uses 5 >> control sequences to WEB's 27. The noweb manual is only 4 pages; >> an additional page explains how to customize its LaTeX output. noweb >> works ``out of the box'' with any programming language, and supports >> TeX, latex, HTML, and troff back ends. A back end to support full >> hypertext or indexing takes about 250 lines; a simpler one can be >> written in 40 lines of awk. The primary sacrifice relative to WEB >> is that code is seldom prettyprinted. >> >> >> >> I removed the elisp support, as the homepage states "In 2012, I learned >> that there is no longer any Emacs mode that supports Noweb and really >> works with Emacs 23 or Emacs 24." >> >> Enjoy! > > Cleaned things up (strcpy, some malloc checks).
Looks fine, except for the following items: - COMMENT should not start with a capital letter or an article - kill the first line of DESCR, as it is the same as COMMENT. I'm wondering whether the last paragraph actually adds value. *shrug* The strcpy/malloc/etc changes don't seem to fix actual problems (sorry if I'm wrong here). Checking for malloc returning NULL is good practice, but the only gain here would be a fatal error message instead of a crash. Also it feels weird to introduce strlcat in an old codebase that still uses a local getline function. I suggest that you propose improvements upstream first. Here's an updated tarball. Can I get another review?
noweb.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
