On Wed, Nov 02, 2016 at 09:55:17AM -0600, attila wrote: > > Landry Breuil <lan...@openbsd.org> writes: > > > On Tue, Oct 18, 2016 at 11:07:22AM -0500, attila wrote: > >> > >> attila <att...@stalphonsos.com> writes: > >> > >> > attila <att...@stalphonsos.com> writes: > >> > > >> >> Hi ports@, > >> >> > >> > Feedback, comments, most welcome. > >> > > >> > Pax, -A > >> > >> Ping. Ports attached for convenience. > > > > Fwiw, i've built the git tip of https://github.com/torbsd/openbsd-ports > > on current, and they build fine. > > I just pushed a couple of times to address your concerns; updated > tarball attached for convenience.
So, more nits portswise only: - meta/tbb/pkg/DESCR could use some more wording, as www/tbb/tor-browser/pkg/DESCR. - i dont see a README anywhere installed in the pkgs (could go to meta/tbb/pkg/README, with the added line to the corresponding PLIST) explaining the end-user how that whole stuff works, without having to refer to the website... - www/tbb/Makefile -> that .if !defined(ADDONS_ONLY) block should go away - no need to cargo-cult BROKEN-sparc64 nor the MODGCC4 stuff for archs where it wont build (yeah i know, i need to clean firefox Makefile..) - the dependency on gettext looks fishy. BUILD_DEPENDS + LIB_DEPENDS + RUN_DEPENDS ? i dont think so, that also looks like cargoculting. - CONFIGURE_STYLE=autoheader ? - since all extensions are installed *only* for tbb, it should be stressed in their COMMENT/DESCR, so that ppl dont think that installing 'https-everywhere' package will magically enabled httpse for their firefox.. And there are probably other nits... :) Landry
