On Tue, Nov 1, 2016, at 06:23 AM, Jeremie Courreges-Anglas wrote: > Jonathan Gray <j...@jsg.id.au> writes: > > > On Mon, Oct 31, 2016 at 07:59:21PM +0100, Jeremie Courreges-Anglas wrote: > >> > >> lua.port.mk doesn't automatically add lua52 and lua53 to FLAVORS any > >> more. So right now the ,lua52 package is broken and I've removed it > >> from lang/Makefile. Either it is decided to keep this FLAVOR (which > >> requires explicitely declaring it in the port Makefile) or the port can > >> be cleaned up. > >> > >> I'd go with the latter, if this package doesn't work with any > >> non-trivial lua lib I see no reason to keep it. But I'm not a luajit > >> user. > > > > Or we remove the FLAVOR and unconditionally enable 5.2 compat > > which will be with 5.1 abi still? > > I guess you'd need to test whether existing luajit consumers still work > if LUAJIT_ENABLE_LUA52COMPAT is defined, because it introduces some > incompatible changes. > > On the other hand: > - other OSes don't seem to enable it (granted, I only checked Debian and > FreeBSD) > - I didn't hear anyone step up to keep LUAJIT_ENABLE_LUA52COMPAT. :) > > I'd just kill it, unless you or abieber@ see value in keeping it.
IIRC tedu@ wanted it for something - I will ping him to see if he has any uses. Personally I don't. > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 > E7EE >
