On Fri, Sep 30, 2016 at 07:56:08AM +0200, Rafael Sadowski wrote:
> New diff:
> 
> - without e2fsprogs and nghttp2 LIB_DEPENDS
> -- port-lib-depends-check looks good
> - replace /usr/local with $TRUEPREFIX
> - portcheck is happy again

This looks good to me: tested this since Friday on amd64.  The
individual build targets work without issues, no compiler warnings,
except the usual string stuff, tests all pass and portcheck is happy.

sthen, if this looks good to you as well and you want to import this and
its dependency libstrophe, ok tb


Rafael, one question: there are two test suites bundled: unit tests and
functional tests. We currently only run the unit tests. Have you looked
into the functional tests?

The functional tests have two additional dependencies that currently
don't have ports, libstabber https://github.com/boothj5/stabber (which
looks very much like WIP and would currently probably only be useful for
this and libmicrohttpd https://www.gnu.org/software/libmicrohttpd/
(which might be useful otherwise). I do have a working port of
libmicrohttpd ready, I can send it if there's any interest.

Reply via email to