On Thu, Sep 29, 2016 at 01:48:23AM +1000, Joel Sing typed: > Thanks for sending this - I had already made a start on it, however had not > gotten to complete the update. > > Some feedback for future reference: > > - If you are bumping the version number the REVISION (if any) can be removed.
Thanks for the feedback. I attach a second version of the patch with REVISION removed inline below. > - The PLIST will often change between releases - `make PLIST` will generate > the updated PLIST, however with lang/go you want to usually run it on > OpenBSD/i386 to avoid unintended changes. I ran on amd64 and filtered out the arch related changes and added 'go/doc/gopher/favicon.svg' as a result below. > - How was the update tested? Did you run `make regress` and if so, on what > architectures? I got "ALL TESTS PASSED" with amd64 (I don't have access to other arch.) It's a relatively minor version bump and I would hope other arch unaffected! Index: Makefile =================================================================== RCS file: /cvs/ports/lang/go/Makefile,v retrieving revision 1.38 diff -u -p -r1.38 Makefile --- Makefile 21 Aug 2016 14:08:25 -0000 1.38 +++ Makefile 29 Sep 2016 10:51:14 -0000 @@ -4,8 +4,7 @@ ONLY_FOR_ARCHS = ${GO_ARCHS} COMMENT = Go programming language -REVISION = 0 -VERSION = 1.7 +VERSION = 1.7.1 EXTRACT_SUFX = .src.tar.gz DISTNAME = go${VERSION} PKGNAME = go-${VERSION} Index: distinfo =================================================================== RCS file: /cvs/ports/lang/go/distinfo,v retrieving revision 1.20 diff -u -p -r1.20 distinfo --- distinfo 18 Aug 2016 17:23:03 -0000 1.20 +++ distinfo 29 Sep 2016 10:51:14 -0000 @@ -1,2 +1,2 @@ -SHA256 (go1.7.src.tar.gz) = cmgMFroIkfzyzPRtD4CeTs9Hu/iJ9diEzLVMXpoX4cA= -SIZE (go1.7.src.tar.gz) = 14091954 +SHA256 (go1.7.1.src.tar.gz) = K4Q/EzuBt5lfJtDLZLvbudBwS5DETfRfhE0oiBrUQtM= +SIZE (go1.7.1.src.tar.gz) = 14098889 cvs diff: Diffing patches cvs diff: Diffing pkg Index: pkg/PLIST =================================================================== RCS file: /cvs/ports/lang/go/pkg/PLIST,v retrieving revision 1.17 diff -u -p -r1.17 PLIST --- pkg/PLIST 18 Aug 2016 17:23:03 -0000 1.17 +++ pkg/PLIST 29 Sep 2016 12:04:20 -0000 @@ -105,6 +105,7 @@ go/doc/gopher/bumper320x180.png go/doc/gopher/bumper480x270.png go/doc/gopher/bumper640x360.png go/doc/gopher/doc.png +go/doc/gopher/favicon.svg go/doc/gopher/fiveyears.jpg go/doc/gopher/frontpage.png go/doc/gopher/gopherbw.png