From reading, I haven't tried building it:
The following line should not have been changed, It should stay as 512x512:
-share/crawl/dat/tiles/stone_soup_icon-512x512.png
+share/crawl/dat/tiles/stone_soup_icon-${MODLUA_DEP_VERSION}2x${MODLUA_DEP_VERSION}2.png
SQLITE_INCLUDE_DIR should use ${LOCALBASE} instead of /usr/local.
REVISION should be removed.
Your ports tree is out of date, we need diffs to be against -current.
On 25 September 2016 05:17:37 "Henrique N. Lengler"
<[email protected]> wrote:
On Sun, Sep 18, 2016 at 12:45:55PM -0300, Henrique N. Lengler wrote:
On Sun, Sep 18, 2016 at 10:35:01AM +0200, Stefan Sperling wrote:
> On Sat, Sep 17, 2016 at 09:48:13PM -0300, Henrique N. Lengler wrote:
> > Could someone give me a feedback, anything wrong?
> >
> > --
> > Henrique N. Lengler
>
> I don't think we should remove BROKEN markers without clear evidence
> that they are no longer required. So please do not delete them unless
> you already got good feedback from ports developers about this change.
> If such a change got committed, and it happens to still be broken,
> we'd just be causing unnecessary duplicate work for people who are
> building ports on these platforms.
> The smartest thing to do would be to submit a separate diff which just
> removes the BROKEN markers and ask for testing, without updating the
> software in the same step. Let's deal with one problem at a time.
Ok, I kept those lines.
> A lot of @comment markers are removed from PLIST in your diff,
> which means the package will now install useless files such as
> stone-soup developer docs. These were @comment'ed out on purpose.
Thanks for pointing, I added @comment on useless files.
> You are removing some patches. Can you explain why you believe
> each of these patches is no longer necessary?
> Are any of these patches now included upstream?
I removed the readme patch because there isn't this file anymore.
The '.des' patches was removed because I couldn't find any problem related
to '.des' files.
> Thank you for picking this up! It's a neat game but I rarely have time
> to play it and even less time to work on updating the port myself.
Again, I've been playing this game for over a week and had no problem, what
else should I do?
I just changed sqlite include to '/usr/local/include', since sqlite is not on
base anymore.
Updated patch attached.
--
Regards,
Henrique N. Lengler
