On 2016/09/17 21:46, Jan Stary wrote: > On Sep 15 12:51:55, h...@stare.cz wrote: > > Would anyone miss the libmagic functionality > > if it was removed from audio/sox? > > On Sep 15 20:36:52, s...@spacehopper.org wrote: > > I wouldn't miss it. > > On Sep 16 11:04:09, a...@caoua.org wrote: > > unlikely; nowadays most (all?) files have the standard extensions > > and the remaining ones are easily handled with file(1). > > So lets just drop it.
Committed, thanks. What do you think about adding this to avoid the massive "sox.h:xxx: warning: 'cdecl' attribute ignored" spam during build on non-i386? Index: Makefile =================================================================== RCS file: /cvs/ports/audio/sox/Makefile,v retrieving revision 1.66 diff -u -p -r1.66 Makefile --- Makefile 20 Sep 2016 10:16:27 -0000 1.66 +++ Makefile 20 Sep 2016 10:16:48 -0000 @@ -5,7 +5,7 @@ BROKEN-hppa = bend.c:155:12: internal co COMMENT= Sound eXchange, the Swiss Army knife of audio manipulation DISTNAME= sox-14.4.2 -REVISION= 0 +REVISION= 1 SHARED_LIBS += sox 4.0 # 3.0 CATEGORIES= audio Index: patches/patch-src_sox_h =================================================================== RCS file: patches/patch-src_sox_h diff -N patches/patch-src_sox_h --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-src_sox_h 20 Sep 2016 10:16:48 -0000 @@ -0,0 +1,12 @@ +$OpenBSD$ +--- src/sox.h.orig Mon Oct 6 03:02:30 2014 ++++ src/sox.h Tue Sep 20 11:14:30 2016 +@@ -44,7 +44,7 @@ Plugins API: + Attribute required on all functions exported by libSoX and on all function + pointer types used by the libSoX API. + */ +-#ifdef __GNUC__ ++#if defined(__GNUC__) && defined(__i386) + #define LSX_API __attribute__ ((cdecl)) /* libSoX function */ + #elif _MSC_VER + #define LSX_API __cdecl /* libSoX function */
