nt/ttcp is broken sine at least 5.9, when support for
sin_family==AF_UNSPEC==0 was removed from bind(2).  ttcp is thus broken
at runtime:

$ ttcp -r > /dev/null
ttcp-r: socket
ttcp-r: bind: Address family not supported by protocol family
errno=47

as reported here:

  http://marc.info/?l=openbsd-misc&m=147318553724853&w=2

It's quite easy to fix, but given...
- the fact that its been broken for two releases (not much, but
  still...)
- the scary build warnings below, that show the age of the code
- the fact that we have much better tools now, such as tcpbench of
  net/iperf

I suggest removing ttcp from the ports tree.  Objections?


cc -O2 -pipe   -o /usr/obj/pobj/ttcp-1.12/build-amd64/ttcp 
/usr/obj/pobj/ttcp-1.12/ttcp.c
/usr/obj/pobj/ttcp-1.12/ttcp.c: In function 'main':
/usr/obj/pobj/ttcp-1.12/ttcp.c:229: warning: incompatible implicit declaration 
of built-in function 'bzero'
/usr/obj/pobj/ttcp-1.12/ttcp.c:244: warning: incompatible implicit declaration 
of built-in function 'bcopy'
/usr/obj/pobj/ttcp-1.12/ttcp.c:263: warning: incompatible implicit declaration 
of built-in function 'malloc'
/usr/obj/pobj/ttcp-1.12/ttcp.c:266: warning: cast from pointer to integer of 
different size
/usr/obj/pobj/ttcp-1.12/ttcp.c:288: warning: passing argument 2 of 'bind' from 
incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c:329: warning: passing argument 2 of 'connect' 
from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c:351: warning: passing argument 2 of 'accept' 
from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c:356: warning: passing argument 2 of 
'getpeername' from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c:438: warning: incompatible implicit declaration 
of built-in function 'exit'
/usr/obj/pobj/ttcp-1.12/ttcp.c: In function 'err':
/usr/obj/pobj/ttcp-1.12/ttcp.c:452: warning: incompatible implicit declaration 
of built-in function 'exit'
/usr/obj/pobj/ttcp-1.12/ttcp.c: In function 'read_timer':
/usr/obj/pobj/ttcp-1.12/ttcp.c:567: warning: incompatible implicit declaration 
of built-in function 'strncpy'
/usr/obj/pobj/ttcp-1.12/ttcp.c: In function 'Nread':
/usr/obj/pobj/ttcp-1.12/ttcp.c:755: warning: passing argument 5 of 'recvfrom' 
from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c: In function 'Nwrite':
/usr/obj/pobj/ttcp-1.12/ttcp.c:785: warning: passing argument 5 of 'sendto' 
from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c: In function 'delay':
/usr/obj/pobj/ttcp-1.12/ttcp.c:806: warning: passing argument 2 of 'select' 
from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c:806: warning: passing argument 3 of 'select' 
from incompatible pointer type
/usr/obj/pobj/ttcp-1.12/ttcp.c:806: warning: passing argument 4 of 'select' 
from incompatible pointer type
/tmp//cc872o5j.o: In function `read_timer':
ttcp.c:(.text+0x70e): warning: warning: sprintf() is often misused, please use 
snprintf()

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to