On Sat 27/08/2016 11:54, Daniel Jakots wrote:
> On Fri, 19 Aug 2016 23:04:16 +0200, Björn Ketelaars
> <bjorn.ketela...@hydroxide.nl> wrote:
> 
> > Please find enclosed a diff for updating sysutils/borgbackup to
> > 1.0.7. This version fixes a security issue with remote repository
> > access.
> > 
> > Full changelog can be found at
> > https://github.com/borgbackup/borg/blob/1.0-maint/docs/changes.rst
> > 
> > Comments/OK?
> > 
> 
> Update looks good to me. I'm a bit concerned by the test suite taking
> much longer than before :
> 
> On 1.0.6
> 1 failed, 489 passed, 62 skipped, 2 xfailed in 557.11 seconds
> On 1.0.7
> 1 failed, 507 passed, 65 skipped, 2 xfailed in 1555.24 seconds
> 
> Is only the test suite that takes longer, did you notice any change
> while using it normally?
> 
> Cheers,
> Daniel 

Daniel,

I'm unable to reproduce your test results:

On 1.0.6
490 passed, 62 skipped, 2 xpassed in 1500.20 seconds
On 1.0.7
508 passed, 65 skipped, 2 xpassed in 1737.95 seconds

Running the test suite from 1.0.7 takes a bit longer than running the suite
from 1.0.6. I'm inclined to blame the additional tests. Results from both test
suites are reproducible (using same machine - amd64).

What is interesting is that you have found a failed test. Could you share the
test logs? It is not unlikely that this failed test explains the difference in
running times.

-- 
Björn Ketelaars
GPG key: 0x4F0E5F21

Reply via email to