Frederic Cambus writes:
> On Sun, Jun 05, 2016 at 10:29:38PM +0200, Frederic Cambus wrote:
> > On Sun, Jun 05, 2016 at 05:10:23AM -0600, Anthony J. Bentley wrote:
> > 
> > > Works fine for me on amd64; building on i386 right now.
> > > 
> > > Please figure out what in the build is causing just .o names to be
> > > printed to the terminal instead of compiler, cflags, etc., and disable
> > > it. Much more helpful to porters when the inevitable build failures
> > > happen at some point in the future. And while you're at it, please
> > > verify that it respects CC/CFLAGS variables--I can't verify due to the
> > > above.
> > 
> > Makes sense, I added a 'do-patch' target in the port Makefile to tweak
> > Makefile.in in order to do so. New tarball attached. I also verified
> > that CC/CFLAGS are respected.
> > 
> > > You mentioned you had an advancemess port too. I'd like to try that
> > > as well.
> > 
> > Sure thing, I'll clean the port and submit it soon then.
> 
> Ping. Let me know if any further modifications are required, still willing
> to work on this if needed.

Overriding do-patch has a caveat; see bsd.port.mk(5). Otherwise it will
probably bite people if the port ever needs patches in the future.
Personally I would just use post-patch instead.

Otherwise, it's okay with me...

Reply via email to