On Thu, 11 Aug 2016 23:55:55 -0700, "Stephen Graf" <s_g...@telus.net>
wrote:

Hi,

> I have sort of built a port for turnserver-4.5.0.3,
> https://github.com/coturn/coturn. 
> 
> I am hoping someone is interested in finishing it or helping me do so
> as I have reached the limits of my abilities.
>
> There is a problem with:
> 
> # make port-lib-depends-check  
> 
> turnserver-4.5.0.3(net/turnserver):
> 
> Missing lib: intl.6 (/usr/local/bin/turnutils_uclient) (NOT REACHABLE)
> 
> And I have not been able to get the .rc script into the package.
> 

Some low hanging fruits:

1) Please remove useless commented lines coming from Makefile.template,
it's harder to review the Makefile with them (noise)

2) I think in MAINTAINER you put upstream's email address. That
shouldn't be that, if you want to be the maintainer put your address or
simply remove the line.

3) Add the correct license used by upstream

4) if it complains about "Missing lib: intl.6" add intl in WANTLIB and
see if it's better

5) What is the problem you have with the rc script?

Also you may want to read (again) the porter's handbook [1]

[1]: https://www.openbsd.org/faq/ports/index.html

Cheers,
Daniel

Reply via email to