On 2016/07/11 22:03, Rafael Sadowski wrote: > Looks like mc works fine with _shadow (maybe without too).
The only time getpw*_shadow functions are needed are when the password field (pw_passwd) are used. These don't need just a search-and-replace for getpw*->getpw*_shadow, they need a small amount of work to figure out what the code is doing. > +--- lib/lock.c.orig Mon Jul 11 18:04:49 2016 > ++++ lib/lock.c Mon Jul 11 18:07:53 2016 > +@@ -91,7 +91,7 @@ lock_build_name (void) > + const char *user = NULL; > + struct passwd *pw; > + > +- pw = getpwuid (getuid ()); > ++ pw = getpwuid_shadow (getuid ()); > + if (pw) > + user = pw->pw_name; > + if (!user) >From the filename I thought this might be some screen-lock thing which might actually need a change, but actually looking at the code it's just creating a lockfile. So NAK to this one. > Index: patches/patch-lib_shell_c And this just wants the shell name. > Index: patches/patch-lib_utilunix_c This does ~username -> /home/username etc. > Index: patches/patch-lib_vfs_interface_c temp dir creation. > Index: patches/patch-lib_vfs_utilvfs_c > Index: patches/patch-src_filemanager_layout_c > Index: patches/patch-src_vfs_fish_fish_c > Index: patches/patch-src_vfs_smbfs_helpers_lib_util_c username/gid lookup. > Index: patches/patch-src_filemanager_achown_c > Index: patches/patch-src_filemanager_chown_c names for list display or something? > Index: patches/patch-src_filemanager_layout_c.orig err.. :) > Index: patches/patch-src_vfs_smbfs_helpers_lib_username_c This is the only one that actually deals with pw_passwd by filling it in from (SunOS's?) getpwanam(). But I don't see anything that actually uses the password field. I think they just pulled across a bunch of (probably samba) code that they don't need. So this looks to me like one of the red herrings I mentioned.
