On Sat, May 14, 2016 at 06:05:44PM +0200, Daniel Jakots wrote:
> New makefile attached (as I didn't touch anything else). I shuffled it
> so it follows the order of Makefile.template (thus easier to read).
> I also added a missed BDEP (sphinx).

Thanks.

> Are you sure the chown in post-install is needed? I installed it
> without and it looked fine, did I miss something?

With the chown:
drwxr-xr-x    4 root  wheel    512 May  9 18:17 .
drwxr-xr-x  141 root  wheel   2560 May 15 23:14 ..
drwxr-xr-x    2 root  wheel    512 May  9 18:17 _sources
drwxr-xr-x    3 root  wheel   1024 May  9 18:17 _static
-r--r--r--    1 root  bin     3465 May  9 18:17 genindex.html
-r--r--r--    1 root  bin    40590 May  9 18:17 index.html
-r--r--r--    1 root  bin      300 May  9 18:17 objects.inv
-r--r--r--    1 root  bin     3760 May  9 18:17 py-modindex.html
-r--r--r--    1 root  bin     4148 May  9 18:17 search.html
-r--r--r--    1 root  bin     4653 May  9 18:17 searchindex.js

Without:
drwxr-xr-x    4 root  wheel    512 May 16 10:22 .
drwxr-xr-x  141 root  wheel   2560 May 16 10:22 ..
drwxr-xr-x    2 root  wheel    512 May 16 10:22 _sources
drwxr-xr-x    3 root  wheel   1024 May 16 10:22 _static
-rw-r--r--    1 root  bin     5699 May 16 10:21 genindex.html
-rw-r--r--    1 root  bin    51471 May 16 10:21 index.html
-rw-r--r--    1 root  bin      411 May 16 10:21 objects.inv
-rw-r--r--    1 root  bin     3760 May 16 10:21 py-modindex.html
-rw-r--r--    1 root  bin     4148 May 16 10:21 search.html
-rw-r--r--    1 root  bin     4872 May 16 10:21 searchindex.js


Looking at the permissions of other python docs in
/usr/local/share/doc/py-*, I think it's correct to not have the docs
root writable. So I would rather leave the chown in place.

Attached is a new tarball with your changes in.

Anyone willing to OK?

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk

Attachment: py-frozen-flask-1.tgz
Description: application/tar-gz

Reply via email to