On Fri, 29 Apr 2016 20:33:38 +0200, Landry Breuil
<[email protected]> wrote:
> On Fri, Apr 29, 2016 at 01:58:02PM +0200, Daniel Jakots wrote:
> > Hi,
> >
> > Here's a port for a new xmpp client which is python3 only and its
> > dependencies net/py3-slixmpp (because python3 only), net/py-aiodns,
> > net/py-cares and security/py-potr (flavoured).
> >
> > Another plugin could use py-inotify but it seems to support only
> > Linux and FreeBSD, talking to a poezio developer he told that it
> > wasn't important and was used only by a plugin for autoaway (when
> > screen/tmux is detached).
> >
> > Most of the tests works fine ; for slixmpp, the output is quite
> > verbose but before the end it says "Ran 362 tests in 10.247s OK"
>
> .if !${FLAVOR:Mpython3} -> im not really comfortable with this
> construct.. isnt there a nicer way to say 'no flavor' ?
I don't know, that's what other ports do:
devel/py-logilab-common/Makefile:.if !${FLAVOR:Mpython3}
devel/py-mock/Makefile:.if !${FLAVOR:Mpython3}
devel/py-nose/Makefile:.if !${FLAVOR:Mpython3}
devel/py-test-benchmark/Makefile:.if !${FLAVOR:Mpython3}
devel/py-test/Makefile:.if !${FLAVOR:Mpython3}
net/py-boto3/Makefile:.if !${FLAVOR:Mpython3}
net/py-s3transfer/Makefile:.if !${FLAVOR:Mpython3}
net/py-zmq/Makefile:.if !${FLAVOR:Mpython3}
security/py-cryptography/Makefile:.if ! ${FLAVOR:Mpython3}}
textproc/py-jellyfish/Makefile:.if !${FLAVOR:Mpython3}
www/py-httplib2/Makefile:.if !${FLAVOR:Mpython3}
www/py-tornado/Makefile:.if !${FLAVOR:Mpython3}
> Why the @mode 644 in poezio's PLIST ? defaults to something else in
> the tarball ?
It looks like that all the files in
lib/python${MODPY_VERSION}/site-packages/poezio/ are set to 444 and
then when you install and launch it, it creates
~/.config/poezio/poezio.cfg in 444 which is 1) not handy to edit 2) not
secure as there is your xmpp password in it.
With the @mode644, when it creates the file it's in 600 which is good.
I just tried to set @mode 600 but then :
PermissionError: [Errno 13] Permission denied:
'/usr/local/lib/python3.4/site-packages/poezio/default_config.cfg'
It sounds a bit hackish so if anyone knows a better way. I tried to
play with post-install but no luck.
FWIW, when talking with the dev, he says "btw, I should fix the umask
here and there becase it quite sucks currently" :p
> Other than that, looks good to me.
Merci :)
> Landry
>
