ok, I fixing....

2016-04-28 16:48 GMT+03:00 Edd Barrett <e...@theunixzoo.co.uk>:

> Hi,
>
> Here's some comments.
>
> On Wed, Apr 27, 2016 at 07:54:58PM +0300, Андрей Болконский wrote:
> > -CATEGORIES =         audio net
> > +CATEGORIES =         audio net python
>
> 'python' is not a category as far as I know.
>
> >  REVISION =           0
>
> You want to remove this. REVISIONs are for newer versions of the OpenBSD
> package, but with the same upstream version.
>
> > -MAINTAINER =                 Edd Barrett <e...@openbsd.org>
> > +MAINTAINER =  Victor Kukshiev (andrey0bolkon...@gmail.com)
>
> This is fine. I don't use this any more, and thus have no real
> motivation to maintain this.
>
> >  MODPY_PI =   Yes
> > +MODPY_SETUPTOOLS =   Yes
>
> Can you make these line up using tabs? There's a few other places in the
> Makefile where you could apply the same strategy.
>
> >  NO_TEST =    Yes
>
> There is a test suite, why not hook it in?
>
> > >> Fetch https://pypi.io/packages/source/p/pylast/pylast-1.6.0.tar.gz
> > pylast-1.6.0.tar.gz 100% |************************| 41307       00:00
> > >> Size does not match for pylast-1.6.0.tar.gz
>
> ^ That's weird. Either upstream re-rolled (which you can't do with PyPI) or
> something went wrong with `make makesum`. Delete your distinfo and re-run
> `make
> makesum`.
>
> Also you need to run `make update-plist`. After you do this, you will see
> that
> the egg info is now a directory. Sadly it's kinda awkward for these dual
> Python
> version ports, as you may need to add MODPY_COMMENT and MODPY_PYCACHE
> manually.
> Grep the tree to see how these are used.
>
> Fix these and send another diff and we can look in more detail.
>
> --
> Best Regards
> Edd Barrett
>
> http://www.theunixzoo.co.uk
>

Reply via email to