On 2016/04/25 18:06, Theo Buehler wrote:
> On Sun, Jan 24, 2016 at 12:13:47PM +0100, Theo Buehler wrote:
> > On Sat, Jan 23, 2016 at 05:20:06PM +0100, Rafael Sadowski wrote:
> > > New updated profanity tarball. Source and changelog on github:
> > > https://github.com/jasperla/openbsd-wip/tree/master/net/profanity
> > >
> > > Thanks for the advice from sthen@ and Raf Czlonka.
> > >
> > > Best regards,
> > >
> > > Rafael
> > 
> > libstrophe now looks fine to me and seems to be ready to go in.
> 
> I've been running the following version of Rafael's net/profanity port
> for quite a while now. The net/libstrophe port is still the same as the
> one submitted by Rafael.
> 
> Does this look ok now?




The libstrophe tar is broken, when you extract it Makefile is a tar.gz of
every file except for Makefile.

This struck me as being a bit odd, some of the configure.ac patches
change from FOO+= to FOO=, like these:

-                     PC_REQUIRES+=(libxml-2.0)
+                     PC_REQUIRES="libxml-2.0 ${PC_REQUIRES}"

but others retain the +

-                              PC_LIBS+=($openssl_LIBS)
+                              PC_LIBS+="${openssl_LIBS} ${PC_LIBS}"

Shouldn't those + go away as well? (Untested due to lack of
usable Makefile ;)


Reply via email to