On Thu, Apr 21, 2016 at 07:08:13PM +0200, Florian Stinglmayr wrote:
> On Thu, Apr 21, 2016 at 08:47:46PM +1000, Jonathan Gray wrote:
> > This could now drop the SHARED_ONLY part.
> >
>
> Yes.
>
> > Why the need to rerun autoconf? Could configure be used as is? Currently
> > the build fails here with:
> >
> > ===> Configuring for lua-lyaml-6.0
> > Using /usr/ports/pobj/lua-lyaml-6.0/config.site (generated)
> > /usr/local/bin/autoreconf[35]: /usr/local/bin/autoreconf-2.13: not found
> >
>
> You are correct. The previous release didn't have a configure, and was
> just a .tar.gz from git master. The appropriate lines have been removed,
> and it still builds and works fine.
>
> Regards,
> Florian
>
The WRKDIST/LIBTOOL_FLAGS lines could go as well.
And libyaml should be LIB_DEPENDS with WANTLIB.
I added LUA_INCLUDE to env as below also.
I'd like to commit it with these changes unless there are any objections?
diff -upr lua-lyaml.orig/Makefile lua-lyaml/Makefile
--- lua-lyaml.orig/Makefile Fri Apr 22 13:14:20 2016
+++ lua-lyaml/Makefile Fri Apr 22 13:41:24 2016
@@ -5,7 +5,6 @@ V = 6.0
DISTNAME = lua-${GH_PROJECT}
PKGNAME = ${DISTNAME}-${V}
-WRKDIST = ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
GH_ACCOUNT = gvvaughan
GH_PROJECT = lyaml
@@ -18,15 +17,16 @@ MAINTAINER = Florian Stinglmayr <flor...@n0la.org>
# MIT
PERMIT_PACKAGE_CDROM = Yes
+WANTLIB = yaml-0
MODULES = lang/lua
-BUILD_DEPENDS = devel/libyaml
+LIB_DEPENDS = devel/libyaml
CONFIGURE_STYLE = gnu
-CONFIGURE_ENV = CPPFLAGS="-I${PREFIX}/include -L${PREFIX}/lib" \
- LUA="${MODLUA_BIN}"
-
-LIBTOOL_FLAGS += --tag=disable-static
+CONFIGURE_ENV = CPPFLAGS="-I${PREFIX}/include" \
+ LDFLAGS="-L${PREFIX}/lib" \
+ LUA=${MODLUA_BIN} \
+ LUA_INCLUDE=-I${MODLUA_INCL_DIR}
# Test requires specl, specl requires lyaml.
NO_TEST = Yes
