On Fri, 15 Apr 2016 22:25:19 +0200
Frederic Cambus <f...@statdns.com> wrote:
> On Fri, Apr 15, 2016 at 01:31:01AM +0200, Adam Wolk wrote:
> >
> > Looks good to me and works correctly. make port-lib-depends-check
> > does complain on extra deps but it did the same for 2.10.
> >
> > vimb-2.11(www/vimb):
> > Extra: iconv.6 m.9 pthread.21
> >
> > vimb-2.10p0(www/vimb):
> > Extra: iconv.6 m.9 pthread.21
> >
>
>
> Indeed, good catch. I believed those issues are now fixed.
>
No complaints for both flavors now.
> Here is an improved diff which removes the extraneous stuff in
> WANTLIB, and moved some of the required libs (fontconfig, freetype,
> pangoft2-1.0 and z) to the else clause of the ${FLAVOR} if block, in
> order to remove such warnings when building the GTK3 flavor.
>
> Also removed devel/gettext from MODULES and added intl to WANTLIB. I'm
> not 100% confident about this modification as portcheck complains
> about it, would be nice if someone could double check.
>
I can confirm the portcheck complaining. Maybe someone more
experienced can weight in, this didn't seem to impact buildtime &
runtime.
> Lastly, this diff drops all the patches by using CFLAGS and MAKE_ENV
> in the port Makefile, and a do-patch section to fix the CA bundle
> path.
>
> > Do you want to take MAINTAINER on this port? There is none in the
> > Makefile now.
>
> Sure, added MAINTAINER.
>
Great. Still OK awolk@ there is no regression from the previous port
except portcheck mentioned in the mail.
Regards,
Adam
