On 2016/04/11 07:42, Jeff Rhyason wrote: > Hi! > > On Apr 11, 2016, at 00:33 , Erling Westenvik <erling.westen...@gmail.com> > wrote: > > > On Sun, Apr 10, 2016 at 09:20:52PM -0700, Jeff Rhyason wrote: > >> vile is widely available in other ports collections and I've been > >> meaning to add it to OpenBSD for a long time. (My first port.) > >> Thanks for any feedback. > > > > Some capitalization issues in pkg/DESCR: > > Thanks! Fixed capitalization from upstream as you suggest. > > Also added the iconv flavor to DESCR. > > http://rhyason.com/vile-openbsd/vile-openbsd.tgz
How useful is it to have iconv optional (rather than either enabling it unconditionally, or disabling it)? rsync and unzip are special cases and shouldn't be taken as examples of how to do things (rsync to allow avoiding deps in a program which is in quite a few cases the only package installed; unzip because it has an intrusive non-upstreamed patch) > notably multi-file editing and viewing, key rebinding, real X window > system support, an optional embedded perl interpreter, and robust > support for non-Unix hosts. > > -the authors of vile are Paul Fox, Tom Dickey, and Kevin Buettner. > +The authors of vile are Paul Fox, Tom Dickey, and Kevin Buettner. > > -many patches have been contributed by a lot of users. we thank them. > +Many patches have been contributed by a lot of users. We thank them. > > -visit > +Visit > ftp://invisible-island.net/vile > ftp://ftp.phred.org/pub/vile > -to be sure it's still the latest. > > +Available flavors: > + iconv - support conversion between different character encodings > + Please zap the blank line at the end of DESCR. I'm not sure if the "Visit ftp://.."; bits are all that useful in DESCR either.
