+cc Peter Haag
On 2016/04/10 20:29, ML mail wrote (on the OpenBSD ports list):
> I am installing nfsen-1.3.7p3 package on OpenBSD 5.8 amd64 but unfortunately
> the install-nfsen.pl script does not work as you can see below:
I'll commit a patch to ports shortly, this got broken in 1.3.7 and isn't
specific to ports.
| Rename gif RRDfiles ... done.
| RRD DB 'peer2.rrd' already exists!
| RRD DB 'upstream1.rrd' already exists!
| RRD DB 'peer1.rrd' already exists!
| Use existing profile info for profile 'live'
|
| Rebuilding profile stats for './live'
| Can't use string ("live") as a HASH ref while "strict refs" in use at
/usr/local/libdata/perl5/site_perl/NfSen/NfProfile.pm line 1238.
| at /usr/local/libdata/perl5/site_perl/NfSen/NfProfile.pm line 1238.
| NfProfile::DoRebuild(HASH(0xd6665c935f8), "live", ".", "live", 1, 0)
called at /usr/local/bin/install-nfsen.pl line 556
| main::UpgradeProfiles(649, 67) called at
/usr/local/bin/install-nfsen.pl line 788
| Debugged program terminated. Use q to quit or R to restart,
| use o inhibit_exit to avoid stopping after program termination,
| h q, h R or h o to get additional info.
diff --git install.pl install.pl
index 9a02b2d..2851304 100755
--- install.pl
+++ install.pl
@@ -553,7 +553,7 @@ sub UpgradeProfiles {
if( ! -f
"$NfConf::PROFILEDATADIR/$profilepath/$channel/.nfstat") {
# no shadow profile, but missing
channel stat
print "Rebuilding profile stats for
'$profilegroup/$profilename'\n";
- NfProfile::DoRebuild(\%profileinfo,
$profilename, $profilegroup, $profilepath, 1, 0);
+ NfProfile::DoRebuild("", \%profileinfo,
$profilename, $profilegroup, $profilepath, 1, 0);
NfProfile::WriteProfile(\%profileinfo);
}
# make sure it's own by nfsen_uid after the
rebuild
diff --git libexec/NfProfile.pm libexec/NfProfile.pm
index 1ca7436..f09cf8a 100644
--- libexec/NfProfile.pm
+++ libexec/NfProfile.pm
@@ -1343,7 +1343,7 @@ sub DoRebuild {
$completed = 100;
}
if ( ($counter % $modulo ) == 0 ) {
- print $socket ".info Rebuilding Profile
'$profile': Completed: $completed\%\n";
+ print $socket ".info Rebuilding Profile
'$profile': Completed: $completed\%\n" if $socket;
syslog('info', "Rebuilding Profile '$profile':
Completed: $completed\%");
}
