On Sun, Apr 03, 2016 at 06:56:13AM +0200, Dmitrij D. Czarkoff wrote:
> Dmitrij D. Czarkoff said:
> > Dmitrij D. Czarkoff said:
> > > Juan Francisco Cantero Hurtado said:
> > > > I just ran "make test" on amd64, so any additional tests are welcome.
> > > > 
> > > > OK?
> > > 
> > > Corresponding update to devel/go-tools.
> > 
> > In previous versions go-tools did not include present and html2article
> > tools.  This happened because both tools had dependencies on golang
> > extra packages from golang.org/x/net which were not available in ports.
> > For the sake of completeness I've ported golang.org/x/net and its
> > dependencies golang.org/x/crypto and golang.org/x/text.
> > 
> > As golang.org/x/net/websocket (net/go-websocket) is a part of
> > golang.org/x/net package set, I suggest to remove it in favor of the
> > whole package set.
> > 
> > I have also updated net/websocketd, the only port depending on
> > net/go-websocket.
> > 
> > OKs?
> 
> Here is the whole go update as a single huge diff including lang/go,
> devel/go-tools, three new go ports, websocketd update and net/websocketd
> removal.  The changes to juanfra@'s lang/go diff boil down to simplified
> install stage - I copy over everything and then remove bootstrap.
> 
> I considered removing tests, but upstream says that go implementation
> should serve a reference for good practices in go development, so these
> tests may serve a reference implementation purposes.
> 
> OK?

Sorry for the delay.

- Use "@comment" for the bootstrap lines in PLIST
- I would prefer to keep the old behavior in do-install. INSTALL_* will
  use the correct permissions for every type of file/dir.

With those changes, OK juanfra@ to everything.

Please wait until the kspillner@ OK for the removal and the jsing@ OK
for the go update.

-- 
Juan Francisco Cantero Hurtado http://juanfra.info

Reply via email to