Jeremie Courreges-Anglas wrote: > > Looks fine to me except: > > 1. pkg_info says > > Comment: > tool to analyse > [...] > > Escaping the # is enough: > COMMENT= tool to analyse \#includes in C and C++ source files > > 2. python interpreter: > > Better use "MODPY_ADJ_FILES = fix_includes.py iwyu_tool.py" than playing > with post-install. Also some people here consider the fixed path > enforced by MODPY_ADJ_FILES as a feature. > > With items #1 and #2 fixed, ok jca@ to import. > > You may also want to get rid of the warning message at configure time: > > CMake Warning at CMakeLists.txt:10 (message): > LLVM_PATH is deprecated, use IWYU_LLVM_ROOT_PATH instead. > > (Replacing LLVM_PATH with IWYU_LLVM_ROOT_PATH in CONFIGURE_ARGS > "works".)
https://github.com/jasperla/openbsd-wip/pull/60 ;)
