On 2016/03/17 23:11, Joerg Jung wrote:
> Please find below a diff which switches irssi-xmpp to the most recent
> GH_COMMIT as of today, which includes a lot of fixes. config_mk patch is
> no longer needed with this and as mentioned above ABI check is also
> already in. I also queried upstream for a new release (last 0.52 was
> back in 2012).
>
> I tested this with both irssi-0.8.17 and 0.8.18 (using the diff posted
> earlier in this thread) and it seems to work fine.
>
> What is the "privmsg-to-self" API change issue about exactly? /query or
> /msg to my own <jid>/resource seems to work and does not crash or
> something.
I haven't used XMPP, but before irssi-icb was fixed, "/msg sthen"
was printing an invalid username when the message was displayed in
the window on my screen. (Maybe the actual behaviour depends on
how malloc.conf is set and what else is in memory nearby).
This is how the API change is described in irssi's NEWS file,
* The signature of "message private" has been changed to
5: server, message, nick, address, target
in order to support "self messages". Module authors should
implement this change if they are using this signal.
Previously it was "4: server, message, nick, address".
The minimal change that was done in irssi-icb was to s/4/5/ and add
server->nick, but actually looking at the bottom of irssi-xmpp TODO
I think that this irssi change is exactly what irssi-xmpp are
asking for in order to solve a problem they had.
> Though, I'm unsure about the DISTNAME and chosen a Debian style name,
> better suggestions are welcome.
packages-specs(7) has information about this, in this case
I think something like this would work:
DISTNAME= irssi-xmpp-0.52pl20160317
> Other than that, OKs?
I think I'd probably commit with the DISTNAME change for now, I'm OK
with that and it should let us move on updating irssi. But also ask
upstream what they suggest about the signature change.
