Aaron Poffenberger said: > Here is a new port : misc/sword [...] > I'm working on porting one of the GUIs to use library but since this is > my first port I'm sending it now for review.
You've left out dependency management (LIB_DEPENDS, WANTLIB). Also, we
normally start SHARED_LIBS from 0.0 for new ports; values are not
supposed to correspond to upstream's library versioning. See attached
tarball for the fixes.
There is also issue with configuration file. It is installed to
${PREFIX}/etc by default, which is not what we normally do. I've set
runtime config file location to ${SYSCONFDIR}, but more work is
required: default configuration file should be installed to
"${PREFIX}/share/examples/sword/" and @sampled to ${SYSCONFDIR} from
there. I don't have time to finish it, so it is left for homework. :)
Overall, I'd say not a bad job for the first port.
--
Dmitrij D. Czarkoff
sword-1.7.5.tgz
Description: application/tar-gz
