On 2016/03/02 19:21, Michael McConville wrote:
> -V=                   1.4.3
> -DISTNAME=            loudmouth-$V
> -REVISION=            6
> +VERSION =            1.5.0
> +DISTNAME =           loudmouth-${VERSION}
> +
>  SHARED_LIBS +=       loudmouth-1          3.0      # .1.0
>  CATEGORIES=          net devel
>  
> -HOMEPAGE=            http://groups.google.com/group/loudmouth-dev/
> +GH_ACCOUNT =         mcabber
> +GH_PROJECT =         loudmouth
> +
> +DISTFILES =          ${VERSION}${EXTRACT_SUFX}

If you're using the GH_* things, you need GH_ACCOUNT, GH_PROJECT and
one (but not both) of GH_COMMIT or GH_TAGNAME.

In this case you want a tagged release, and the defaults implied by GH_*
are ok for the other bits of this, so remove VERSION DISTNAME DISTFILES
and use these below COMMENT:

GH_ACCOUNT =            mcabber
GH_PROJECT =            loudmouth
GH_TAGNAME =            1.5.0

(actually there is a 1.5.3 now)

This is briefly shown in current versions of Makefile.template.

> +BUILD_DEPENDS =              ${TEST_DEPENDS} \
> +                     ${MODGNU_AUTOCONF_DEPENDS} \
> +                     ${MODGNU_AUTOMAKE_DEPENDS} \
> +                     devel/libtool

yep.

> +CONFIGURE_STYLE =    autoconf automake gnu
> +AUTOCONF_VERSION =   2.69
> +AUTOMAKE_VERSION =   1.15
..
> +AUTO_ENV =           AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> +                     AUTOCONF_VERSION=${AUTOCONF_VERSION}
> +
> +post-patch:
> +     cd ${WRKSRC}; ${AUTO_ENV} aclocal
> +
> +pre-configure:
> +     cd ${WRKSRC}; libtoolize && ${AUTO_ENV} automake --add-missing --foreign

They have an autogen.sh script so it's probably better to use it.
I would do it like this: (note: untested)

CONFIGURE_STYLE = gnu
AUTOCONF_VERSION =   2.69
AUTOMAKE_VERSION =   1.15

post-patch:
        cd ${WRKSRC}; AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
            AUTOCONF_VERSION=${AUTOCONF_VERSION} sh autogen.sh

Doesn't apply in this case but some of them run ./configure at the
end, patch it away if they do.

> --- distinfo  18 Jan 2015 03:14:42 -0000      1.6
> +++ distinfo  3 Mar 2016 00:09:35 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (loudmouth-1.4.3.tar.bz2) = 
> lak/XQCbceqBk9mUqhHzEbwzCj7+G3zXTcSPEcf5KeM=
> -SIZE (loudmouth-1.4.3.tar.bz2) = 366818
> +SHA256 (1.5.0.tar.gz) = UUAxemOEUMl3pynexUW1lTjqSy5Rndcj07/aEsonhmU=
> +SIZE (1.5.0.tar.gz) = 124001

Covered by the above GH_foo changes, but note that this has to go
in a directory with ~8000 other files, 1.5.0.tar.gz isn't a usable
name.

I haven't looked at the patches.

Reply via email to