On Sun, Feb 07, 2016 at 06:06:48PM -0500, Jiri B wrote: > We need to explicitly disable pulling of wireshark inside libvirt port > or if not, libvirt port should has subpackage (as Fedora[1] does) for > wireshark dissector plugin (IMO not much used on OpenBSD). > > j. Thanks, I'll handle it. The diff is not right as the REVISION bump is not needed (for the package doesn't change). I agree there's little point in adding a wireshark subpackage, at least I've never had any need for it. > [1] https://pkgs.fedoraproject.org/cgit/rpms/libvirt.git/tree/libvirt.spec > > ... > configure: wireshark_dissector: yes (CFLAGS='-I/usr/local/include/wireshark' > LIBS='-L/usr/local/lib -lwireshark') > ... > configure: Wireshark dissector: yes > ... > mkdir -p wireshark/src/libvirt > cd wireshark/src && \ > LIBVIRT_VERSION=1.3.1 \ > /usr/bin/perl > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/tools/wireshark/util/genxdrstub.pl > \ > > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/src/remote/remote_protocol.x > > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/src/remote/qemu_protocol.x > > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/src/remote/lxc_protocol.x > > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/src/rpc/virkeepaliveprotocol.x > Use of uninitialized value in subroutine entry at > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/tools/wireshark/util/genxdrstub.pl > line 580. > Cannot open file /libvirt/remote.h: No such file or directory at > /home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/tools/wireshark/util/genxdrstub.pl > line 581. > Makefile:3200: recipe for target 'wireshark/src/libvirt/protocol.h' failed > gmake[3]: *** [wireshark/src/libvirt/protocol.h] Error 2 > gmake[3]: Leaving directory > '/home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/tools' > Makefile:2105: recipe for target 'all' failed > gmake[2]: *** [all] Error 2 > gmake[2]: Leaving directory > '/home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1/tools' > Makefile:2004: recipe for target 'all-recursive' failed > gmake[1]: *** [all-recursive] Error 1 > gmake[1]: Leaving directory > '/home/jirib/openbsd/pobj/libvirt-1.3.1/libvirt-1.3.1' > Makefile:1899: recipe for target 'all' failed > gmake: *** [all] Error 2 > *** Error 2 in . > (/home/jirib/cvs/openbsd-ports/infrastructure/mk/bsd.port.mk:2773 > '/home/jirib/openbsd/pobj/libvirt-1.3.1/.build_done') > *** Error 1 in /usr/ports/sysutils/libvirt > (/home/jirib/cvs/openbsd-ports/infrastructure/mk/bsd.port.mk:2495 'all') > > ~~~ > Index: Makefile > =================================================================== > RCS file: /cvs/ports/sysutils/libvirt/Makefile,v > retrieving revision 1.46 > diff -u -p -r1.46 Makefile > --- Makefile 17 Jan 2016 14:25:12 -0000 1.46 > +++ Makefile 7 Feb 2016 23:05:05 -0000 > @ -3,7 +3,7 @@ > COMMENT= tool/library for managing platform virtualization > > DISTNAME= libvirt-1.3.1 > -REVISION= 0 > +REVISION= 1 > CATEGORIES= sysutils devel > > SHARED_LIBS += virt-qemu 0.4 # 1003.0 > @ -49,6 +49,7 @@ CONFIGURE_ARGS+= ${CONFIGURE_SHARED} \ > --without-netcf \ > --without-network \ > --without-login-shell \ > + --without-wireshark-dissector \ > # OpenBSD can't act as a virtualization host, so no need for libvirtd. > # If support is added, subtitute /var/lib/{xen,virt,libvirt,...} with /var/db > CONFIGURE_ARGS+= --without-libvirtd > ~~~ >
-- jasper
