On Wed, Jan 13, 2016 at 1:14 AM, Cesare Gargano <g...@plusiagamma.org> wrote:
> On 01/06, Cesare Gargano wrote:
>> On 01/04, Nigel Taylor wrote:
>> > On 01/04/16 21:02, Cesare Gargano wrote:
>> > > Hi!
>> > > This updates www/p5-Plack to 1.0039. Attached 2 new deps.
>> > >
>> > > We have OK from MAINTAINER.
>> > >
>> > > www/p5-Cookie-Baker:
>> > > Cookie::Baker provides simple cookie string generator and parser.
>> > >
>> > > devel/p5-Test-Time:
>> > > Test::Time can be used to test modules that deal with time.
>> > > Once you use this module, all references to time and sleep will be
>> > > internalized.
>> > >
>> > > All tests passed.
>> > >
>> > > Comments, OK?
>> > >
>> > p5-Test-Time - should be modinst style. Your need the Module::Install
>> > extensions to switch to using modinst. See Makefile.PL
>> >
>> > Module::Install::AuthorTests
>> > Module::Install::Repository
>> > Module::Install::ReadmeFromPod
>> > Module::Install::TestBase
>> >
>> > I have the new ports for these extensions, so can switch port to modinst
>> > later.
>> >
>> > Upstream source file is wrong, it has included core perl modules within
>> > the source, normally wrong unless a good reason, may break on moving to
>> > newer perl versions. Should try to use OpenBSD supplied perl modules
>> > that have been tested and may include patches.
>> >
>> > Includes Spiffy 0.30 within the source, the version in ports is 0.46,
>> > from Spiffy change log...
>> >
>> > 0.40 Wed Aug 6 10:29:46 PDT 2014
>> > - Fix a bug that was causing lots of warnings in Test::Base on perl 5.21
>> >
>> > Moving to perl 5.22, will hit this bug, if modinst with modified
>> > bsd.perl.mk isn't used, Only affects testing in this case...
>> >
>> > Should be no problem for this release, does need fixing for next release
>> > / move to perl 5.22.
>> >
>> >
>> > p5-Cookie-Baker - using correct modbuild style.
>> >
>> >
>> > p5-Plack - Can't see any issue from scanning.
>> >
>>
>> Hi,
>> after some more words with nigel@ (about changes after perl 5.22 in tree),
>> attached the p5-Plack diff and its new 2 deps. I modified p5-Test-Time
>> to include devel/p5-File-Slurp in TEST_DEPENDS, as suggested by nigel@.
>>
>> OK from MAINTAINER, OK from nigel@ (thank you!)
>>
>> --
>> C.
>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/www/p5-Plack/Makefile,v
>> retrieving revision 1.8
>> diff -u -p -r1.8 Makefile
>> --- Makefile 18 Jan 2015 13:13:37 -0000 1.8
>> +++ Makefile 20 Dec 2015 10:49:13 -0000
>> @@ -3,7 +3,7 @@
>> COMMENT = interface between perl web frameworks and web servers
>>
>> MODULES = cpan
>> -DISTNAME = Plack-1.0033
>> +DISTNAME = Plack-1.0039
>> CATEGORIES = www
>> MAINTAINER = Abel Abraham Camarillo Ojeda <acam...@verlet.org>
>>
>> @@ -21,7 +21,9 @@ RUN_DEPENDS = devel/p5-Devel-StackTrace>
>> net/p5-Test-TCP>=2.00 \
>> sysutils/p5-Filesys-Notify-Simple>=0 \
>> www/p5-Apache-LogFormat-Compiler>=0.12 \
>> + www/p5-Cookie-Baker>=0.05 \
>> www/p5-HTTP-Body>=1.06 \
>> + www/p5-HTTP-Headers-Fast>=0.18 \
>> www/p5-HTTP-Message>=5.814 \
>> www/p5-URI>=1.59
>>
>> Index: distinfo
>> ===================================================================
>> RCS file: /cvs/ports/www/p5-Plack/distinfo,v
>> retrieving revision 1.4
>> diff -u -p -r1.4 distinfo
>> --- distinfo 18 Jan 2015 13:13:37 -0000 1.4
>> +++ distinfo 20 Dec 2015 10:49:13 -0000
>> @@ -1,2 +1,2 @@
>> -SHA256 (Plack-1.0033.tar.gz) = vNh4S4JjvW1oR26dUub5iBm9TzMxRVytEu/+1jp4MiA=
>> -SIZE (Plack-1.0033.tar.gz) = 239206
>> +SHA256 (Plack-1.0039.tar.gz) = 0kpXLohkTH05x+b/GvAFtyjeyUqHjPBtkCerfRov0Kk=
>> +SIZE (Plack-1.0039.tar.gz) = 176711
>> Index: pkg/PLIST
>> ===================================================================
>> RCS file: /cvs/ports/www/p5-Plack/pkg/PLIST,v
>> retrieving revision 1.3
>> diff -u -p -r1.3 PLIST
>> --- pkg/PLIST 18 Jan 2015 13:13:37 -0000 1.3
>> +++ pkg/PLIST 20 Dec 2015 10:49:13 -0000
>> @@ -1,5 +1,6 @@
>> @comment $OpenBSD: PLIST,v 1.3 2015/01/18 13:13:37 benoit Exp $
>> bin/plackup
>> +${P5SITE}/HTTP/
>> ${P5SITE}/HTTP/Message/
>> ${P5SITE}/HTTP/Message/PSGI.pm
>> ${P5SITE}/HTTP/Server/
>> @@ -86,6 +87,9 @@ ${P5SITE}/Plack/Test/Suite.pm
>> ${P5SITE}/Plack/Util/
>> ${P5SITE}/Plack/Util.pm
>> ${P5SITE}/Plack/Util/Accessor.pm
>> +${P5SITE}/auto/
>> +${P5SITE}/auto/share/
>> +${P5SITE}/auto/share/dist/
>> ${P5SITE}/auto/share/dist/Plack/
>> ${P5SITE}/auto/share/dist/Plack/#foo
>> ${P5SITE}/auto/share/dist/Plack/baybridge.jpg
>
> Ping.
>
> --
> C.
>
I think you should get dependencies commited independently, so
this would go in easier
ps - i still think the PLIST chunk is unnecesary
or can anyone commit this - including deps?
thanks!
