On Fri, Jan 08, 2016 at 10:15:28PM +0000, Stuart Henderson wrote:
> Looks like this picks up dbus if present during build; should we add
> a dependency or disable it?
>
> ...
> CC build/SDL_x11clipboard.lo
> cc -O2 -pipe -I/usr/local/include -DUSING_GENERATED_CONFIG_H -Iinclude
> -I/usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/include -mmmx -msse
> -fvisibility=hidden -I/usr/X11R6/include -I/usr/local/include/dbus-1.0
> -I/usr/local/lib/dbus-1.0/include -DHAVE_USBHID_H -DUSBHID_UCR_DATA
> -DUSBHID_NEW -D_REENTRANT -Wall -MMD -MT build/SDL_x11clipboard.lo -c
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/SDL_x11clipboard.c -fPIC
> -DPIC -o build/.libs/SDL_x11clipboard.o
> In file included from
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/SDL_x11video.h:59,
> from
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/SDL_x11clipboard.c:28:
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/../../core/linux/SDL_dbus.h:30:23:
> warning: dbus/dbus.h: No such file or directory
> In file included from
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/SDL_x11video.h:59,
> from
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/SDL_x11clipboard.c:28:
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/../../core/linux/SDL_dbus.h:34:
> error: expected specifier-qualifier-list before 'DBusConnection'
> Error while executing cc -O2 -pipe -I/usr/local/include
> -DUSING_GENERATED_CONFIG_H -Iinclude
> -I/usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/include -mmmx -msse
> -fvisibility=hidden -I/usr/X11R6/include -I/usr/local/include/dbus-1.0
> -I/usr/local/lib/dbus-1.0/include -DHAVE_USBHID_H -DUSBHID_UCR_DATA
> -DUSBHID_NEW -D_REENTRANT -Wall -MMD -MT build/SDL_x11clipboard.lo -c
> /usr/obj/ports/sdl2-2.0.4/SDL2-2.0.4/src/video/x11/SDL_x11clipboard.c -fPIC
> -DPIC -o build/.libs/SDL_x11clipboard.o
>
It looks like it is used to disable the screensaver and for communicating with
the ibus input method.
So either we add deps for inputmethods/ibus, devel/libinotify (for SDL_ibus.c),
and x11/dbus or disable it.
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/sdl2/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- Makefile 7 Jan 2016 04:49:37 -0000 1.10
+++ Makefile 8 Jan 2016 22:40:34 -0000
@@ -3,6 +3,7 @@
COMMENT= cross-platform multimedia library
V= 2.0.4
+REVISION= 0
DISTNAME= SDL2-${V}
PKGNAME= sdl2-${V}
CATEGORIES= devel
@@ -27,7 +28,9 @@ CONFIGURE_ARGS+= ${CONFIGURE_SHARED} \
--disable-arts \
--disable-esd \
--disable-oss \
- --disable-pulseaudio
+ --disable-pulseaudio \
+ --disable-dbus \
+ --disable-ibus
# in case devel/usb is installed, don't pick it up.
CONFIGURE_ENV+= ac_cv_lib_usb_hid_init=no \
ac_cv_header_usb_h=no
