On 10/28/15 22:48, Stuart Henderson wrote:
> On 2015/10/28 14:14, Nigel wrote:
>> As a github project, wonder why GH_PROJECT, GH_TAGNAME, GH_ACCOUNT
>> aren't being used.
>
> GH_* are for the dynamically-generated tarballs that you need to use
> for lazy projects. Since nghttp2 is one of the few github projects
> that actually makes proper release tarballs it makes sense to use
> them.
>
Nothing difficult in making tarballs just run git archive and upload.
GitHub is currently expecting to use the standard dynamic tarballs not
the uploaded tarballs.
>> make test, doesn't appear to run any tests.
>
> I'm not sure if there's a better way to handle this. It needs cunit
> present at configure time to run the tests, but cunit isn't available
> on all architectures that curl is available on - I'd rather have a
> manual step needed for tests than to risk knocking out curl from an
> arch. (Better ideas welcome of course :-)
>
Built and ran tests with cunit installed, passed the 2 tests.
Just the easy case amd64.
sh & vax don't have cunit, so can either skip including nghttp2 in curl
as nghttp2 can't be tested, curl itself doesn't look like it does much
testing of nghttp2 and the --http2 option.
Best I could come up with so far.....
TEST_DEPENDS = devel/cunit
pre-test:
rm ${WRKDIR}/build-amd64/.configure_done
make configure
replace rm ... with rm ${_CONFIGURE_COOKIE}
might be able to use
${CONFIGURE_ENV} ${_CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}
in place of rm/make configure
>> The man pages are for tools which are not in the package,
>> h2load.1 nghttp.1 nghttpd.1 nghttpx.1.
>
> Landry spotted this too, I've @commented them now.
>
>> curl depending on nghttp2, I think it should.
>
Can't test anything else. Ok with this on amd64.
