Stuart Henderson <st...@openbsd.org> writes: > On 2015/10/04 22:41, Mikolaj Kucharski wrote: >> On Sun, Oct 04, 2015 at 10:15:12PM +0100, Mikolaj Kucharski wrote: >> > I would appreciate if someone look is my change sane. As this is long >> > overdue update from 0.4 to 0.6 which has also different upstream, I >> > decided to include whitespace changes in Makefile, as this update is >> > intrusive. >> >> - switch to sed -i >> - fix regress tests >> - all regress tests pass > > Looks good to me. The patch-README diff in your mail doesn't apply > directly, but it's just 'cvs rm' anyway so that's easy to fix. > > Would you be interested in taking MAINTAINER?
FWIW, looks good to me too, ok jca@ Mikolaj: note that upstream already has AC_C_BIGENDIAN in its configure.ac and already uses it... *except* when the system has an <endian.h> include file. That special case is where the bug was introduced; what was the reason for this special case? Which reminds me that some versions of AC_C_BIGENDIAN are broken on powerpc... -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE