On 07/14/15 22:58, Jérémie Courrèges-Anglas wrote:
Fred <open...@crowsons.com> writes:
Hi,
Hi,
Attached is an update to py-serial I have lightly tested on amd64.
Thanks
Thanks for your diff.
Some comments:
- unnecessary whitespace changes in the Makefile
- make plist is confused by the fact that ${MODPY_VERSION} ==
${MODPY_EGG_VERSION}. Since "MODPY_EGG_VERSION" is longer than
"MODPY_VERSION", some occurrences of "MODPY_VERSION" are incorrectly
replaced. make plist can only make guesses.
- this switch:
-share/doc/py-serial/
-share/doc/py-serial/LICENSE.txt
-share/doc/py-serial/README.txt
-share/examples/py-serial/
-share/examples/py-serial/enhancedserial.py
[...]
+share/doc/${MODPY_PY_PREFIX}serial/
+share/doc/${MODPY_PY_PREFIX}serial/LICENSE.txt
+share/doc/${MODPY_PY_PREFIX}serial/README.txt
+share/examples/${MODPY_PY_PREFIX}serial/
+share/examples/${MODPY_PY_PREFIX}serial/enhancedserial.py
[...]
is IMO correct. Keeping "py-" hardcoded in PLIST would prevent
a python3 package to be installed along with a python2 package. Since
python3 is supported upstream, here's an updated diff that adds support
for a python3 flavor.
No serial stuff handy so I'd appreciate more tests.
Comments / ok?
Thanks for the pointers. Yes that's better diff - it's working fine with
my arduino on amd64 - will test on i386 with a different serial device.
Cheers fred
