On Wed, Apr 22, 2015 at 03:47:14PM -0500, Kent R. Spillner wrote: > On Sun, Mar 29, 2015 at 01:07:52PM +0200, Fabian Raetz wrote: > > Updated port to use the newly defined GO_ARCHS variable. > > Any comments and/or feedback? > > Hey, sorry for letting this slip through the cracks but I finally just > got around to checking it out. Looks good, but I noticed that a new > version is out. I tried your version first, and then I tried to upgrade > to a newer version (attached). > > Also, you'll need to either set NO_TEST or else provide a do-test target. > I added a do-test that calls script/test and I also had to patch the way > script/build calls find(1), but the tests don't pass. Do you think you > can look into the failures and work out what's going wrong? See below > for the output I see locally when I try running the tests (everything > from the "tmux: unknown option -- V" line down comes from the Ruby > tests, but as you can see some of the Go tests failed too). > > I fear that the Ruby/Cucumber tests will be difficult to get working in > this port because we don't want Bundler to download any gems during > builds, but rather then set NO_TEST = yes I would prefer to fix the Go > tests and patch script/test to skip running the Ruby tests. What do > you think? Of course, if you want to tackle the Ruby stuff as well be > my guest (and patch script/ruby-test to fix the tmux check). ;)
Hi,
i finally found some time to look at this again. The go test cases were
failing because they depend on an initialized git repo in ${WRKSRC}
which i create now in do-test.
This fixes all go tests for me.
The cucumber tests are disabled for now. I will dig into this at some
point and see how much work it will be to hook them up.
New version is attached (and in openbsd-wip by the way)
Thanks,
Fabian
>
> $ make test
> ===> Regression tests for hub-2.2.1
> cd /usr/obj/ports/hub-2.2.1/hub-2.2.1 && script/test
> ? _/usr/obj/ports/hub-2.2.1/hub-2.2.1 [no test files]
> ok _/usr/obj/ports/hub-2.2.1/hub-2.2.1/cmd 0.041s
> exit status 1
> FAIL _/usr/obj/ports/hub-2.2.1/hub-2.2.1/commands 0.236s
> ? _/usr/obj/ports/hub-2.2.1/hub-2.2.1/fixtures [no test files]
> ok _/usr/obj/ports/hub-2.2.1/hub-2.2.1/git 1.387s
> --- FAIL: TestGetMessageFile (0.02s)
> assert.go:16:
> /usr/obj/ports/hub-2.2.1/hub-2.2.1/github/editor_test.go:166
> assert.go:37: ! Failure
> FAIL
> FAIL _/usr/obj/ports/hub-2.2.1/hub-2.2.1/github 0.687s
> ? _/usr/obj/ports/hub-2.2.1/hub-2.2.1/ui [no test files]
> ok _/usr/obj/ports/hub-2.2.1/hub-2.2.1/utils 0.015s
> tmux: unknown option -- V
> usage: tmux [-2lquv] [-c shell-command] [-f file] [-L socket-name]
> [-S socket-path] [command [flags]]
> warning: skipping shell completion tests (install tmux to enable)
> script/ruby-test: line 7: 517 Bad system call (core dumped)
> RUBYOPT="$RUBYOPT -w" bundle exec "$@" 2> >(tee >(grep 'warning:'
> >>"$warnings") | grep -v 'warning:')
> *** Error 140 in . (Makefile:35 'do-test')
> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2779
> '/usr/obj/ports/hub-2.2.1/.test_done')
> *** Error 1 in /usr/ports/devel/hub
> (/usr/ports/infrastructure/mk/bsd.port.mk:2476 'test')
hub-2.2.1.tar.gz
Description: application/tar-gz
