On 01/18/15 13:43, Cesare Gargano wrote:
> Hi!
> I followed your comments, attached new diff using meta/Module-Install
> (I created the 4 missing p5-* deps) instead of devel/p5-Module-Install.
>
> Can we have meta/Module-Install in tree to start using it?
>
> Thanks!
>
> --
> C.
>
> On Sun, Jan 18, 2015 at 1:50 AM, Nigel J Taylor <ni...@openbsd.org> wrote:
>> A quick look and I need to do checks once my build completes building,
>> so it's a visual inspection only...
>>
>> BUILD_DEPENDS = ${RUN_DEPENDS} should be kept, and
>> append devel/p5-Test-Requires and the missing p5-Test-SharedFork.
>>
>> The configure stage then checks the presence of modules,
>> and versions if given.
>>
>> p5-Class-Accessor-Lite>=0.04
>> p5-Proc-Wait3>=0.03
>>
>> TEST_DEPENDS doesn't need to contain anything that is in the
>> BUILD_DEPENDS, test are run on what's built p5-Test-Requires
>> p5-Test-SharedFork in the BUILD_DEPENDS they are not needed in the
>> TEST_DEPENDS.
>>
>> Looking at test test 05 this would fail if run, haven't tried but has a
>> use Test::SharedFork building something else might have installed this,
>> however dpb builds can junk packages that are not dependencies, and
>> uninstall them.
>>
>> Checking the source, this uses Module::Install, that requires
>> the Makefile to have a style of modinst, otherwise an old
>> bundled version of Module::Install will be used rather than the ports
>> version,
>>
>> Your find this
>> inc/Module/Install/ReadmeFromPod.pm in the source.
>> For that you might need the new extension package I have, for the
>> modinst style to work
>>
>> devel/p5-Module-Install-ReadmeFromPod
>>
>> Using modinst style also stops the port when building from downloading
>> and installing from CPAN anything that is missing such as dependencies
>> or dependencies dpb junk might have removed.
>>
>>
>>
>> I have a number of ports where I switched the style to modinst, this is
>> so things will be less of a problem with perl 5.22.0 and the CPAN
>> download issue.
>>
>> I use a replacement for p5-Module-Install in perl.port.mk
>>
>> @@ -52,7 +52,7 @@ MODPERL_configure = ${_MODPERL_preconfig
>> fi
>>
>> . if ${CONFIGURE_STYLE:L:Mmodinst}
>> -BUILD_DEPENDS += devel/p5-Module-Install
>> +BUILD_DEPENDS += meta/Module-Install
>>
>> Then installs all the Module::Install extensions, rather than
>> adding each one to the ports until modinst stops failing, or creating a
>> long list in perl.port.mk, there was some other problem this solved.
>>
>>
>> # $OpenBSD: Makefile,v 1.111 2014/11/13 17:34:21 ajacoutot Exp $
>>
>> COMMENT= meta - module install and extensions
>>
>> PKGNAME= Module-Install-0.01
>>
>> MAINTAINER= Nigel Taylor <ni...@openbsd.org>
>>
>> RUN_DEPENDS += devel/p5-Module-Install \
>> devel/p5-Module-Install-CheckLib \
>> devel/p5-Module-Install-GithubMeta \
>> devel/p5-Module-Install-ReadmeFromPod \
>> devel/p5-Module-Install-TestBase
>>
>> .include <bsd.port.mk>
>>
>>
>>
>> On 01/17/15 20:58, Cesare Gargano wrote:
>>> Ping
>>>
>>> On Thu, Jan 8, 2015 at 8:15 PM, Cesare Gargano <g...@plusiagamma.org> wrote:
>>>> Hi ports@!
>>>>
>>>> Update to 0.17, needed for upcoming update to www/p5-Starlet.
>>>>
>>>> Tested on amd64.
>>>>
>>>> Index: Makefile
>>>> ===================================================================
>>>> RCS file: /cvs/ports/devel/p5-Parallel-Prefork/Makefile,v
>>>> retrieving revision 1.4
>>>> diff -u -r1.4 Makefile
>>>> --- Makefile 11 Mar 2013 10:50:20 -0000 1.4
>>>> +++ Makefile 8 Jan 2015 18:53:11 -0000
>>>> @@ -2,20 +2,22 @@
>>>>
>>>> COMMENT= simple prefork server framework
>>>>
>>>> -DISTNAME= Parallel-Prefork-0.11
>>>> -REVISION= 1
>>>> +MODULES= cpan
>>>> +DISTNAME= Parallel-Prefork-0.17
>>>> CATEGORIES= devel
>>>>
>>>> # Perl
>>>> PERMIT_PACKAGE_CDROM= Yes
>>>>
>>>> -MODULES= cpan
>>>> +
>>>> +BUILD_DEPENDS= devel/p5-Test-Requires
>>>>
>>>> RUN_DEPENDS= devel/p5-Class-Accessor-Lite \
>>>> devel/p5-List-MoreUtils \
>>>> + sysutils/p5-Proc-Wait3 \
>>>> devel/p5-Scope-Guard \
>>>> - sysutils/p5-Proc-Wait3
>>>> -BUILD_DEPENDS= ${RUN_DEPENDS}
>>>> -TEST_DEPENDS=devel/p5-Test-Requires
>>>> + devel/p5-Signal-Mask
>>>> +
>>>> +TEST_DEPENDS= devel/p5-Test-Requires
>>>>
>>>> .include <bsd.port.mk>
>>>> Index: distinfo
>>>> ===================================================================
>>>> RCS file: /cvs/ports/devel/p5-Parallel-Prefork/distinfo,v
>>>> retrieving revision 1.1.1.1
>>>> diff -u -r1.1.1.1 distinfo
>>>> --- distinfo 14 Jun 2011 12:13:08 -0000 1.1.1.1
>>>> +++ distinfo 8 Jan 2015 18:53:11 -0000
>>>> @@ -1,5 +1,2 @@
>>>> -MD5 (Parallel-Prefork-0.11.tar.gz) = 1Lk0fEFOfw0wcI4U4F7jpg==
>>>> -RMD160 (Parallel-Prefork-0.11.tar.gz) = hjxU532Q8HFOhiYL9+JE7dJPu1s=
>>>> -SHA1 (Parallel-Prefork-0.11.tar.gz) = sVYNm2IL7fBWUwtBLzWkUcgn1ms=
>>>> -SHA256 (Parallel-Prefork-0.11.tar.gz) =
>>>> flLnrLdQW0SBBP6cVpZDWMPSeqn1p94vGp5A65PZmrc=
>>>> -SIZE (Parallel-Prefork-0.11.tar.gz) = 24782
>>>> +SHA256 (Parallel-Prefork-0.17.tar.gz) =
>>>> DYHeJjIoEJG9MSl94ZBuFMrk6EXPMiAJU7UEBoWedjs=
>>>> +SIZE (Parallel-Prefork-0.17.tar.gz) = 26023
>>>>
>>>> --
>>>> C.
>>>>
>>>
>>>
>>
The changes I made to run here using modinst style....
$ diff -uNPr p5-Parallel-Prefork{,.new}
diff -uNPr p5-Parallel-Prefork/Makefile p5-Parallel-Prefork.new/Makefile
--- p5-Parallel-Prefork/Makefile Tue Jan 20 15:59:59 2015
+++ p5-Parallel-Prefork.new/Makefile Tue Jan 20 16:01:09 2015
@@ -9,7 +9,10 @@
# Perl
PERMIT_PACKAGE_CDROM= Yes
+CONFIGURE_STYLE += modinst
+
BUILD_DEPENDS= ${RUN_DEPENDS} \
+ devel/p5-Parallel-Scoreboard \
devel/p5-Test-Requires \
devel/p5-Test-SharedFork
I added p5-Parallel-Scorebaord - new port required to do all tests...
It's version 0.05 but MANIFEST includes 0.04 tar, so wrong, and haven't done a
proper description in DESCR, only done enough to create a package and do tests.
Test 04 includes this, first appeared in 0.09 of Parallel-Prefork....
use Test::Requires qw(Parallel::Scoreboard);
use Test::More tests => 6;
my $sb = Parallel::Scoreboard->new(
base_dir => File::Temp::tempdir(CLEANUP => 1),
);
Appears to be completely missing as a dependency. I'm OK to go ahead with
the port, as is. The changes I have can be used to update later, they only
change the build, not the end package result. Missing/Skipped test does work.
$ sudo pkg_delete -a
p5-Class-Accessor-Lite-0.06: ok
groff-1.22.3: ok
p5-List-MoreUtils-0.33p1: ok
Read shared items: ok
$ make print-build-depends | cut -d'"' -f2 | xargs sudo pkg_add -a
quirks-2.50 signed on 2015-01-20T13:01:13Z
p5-File-Remove-1.52: ok
......
Module-Install-0.01: ok
p5-Parallel-Scoreboard-0.05: ok
Look in /usr/local/share/doc/pkg-readmes for extra documentation.
$ make test
===> Checking files for p5-Parallel-Prefork-0.17
`/usr/ports/distfiles/Parallel-Prefork-0.17.tar.gz' is up to date.
>> (SHA256) Parallel-Prefork-0.17.tar.gz: OK
===> p5-Parallel-Prefork-0.17 depends on: p5-Class-Accessor-Lite->=0.04 ->
p5-Class-Accessor-Lite-0.06
===> p5-Parallel-Prefork-0.17 depends on: p5-List-MoreUtils-* ->
p5-List-MoreUtils-0.33p1
===> p5-Parallel-Prefork-0.17 depends on: p5-Proc-Wait3->=0.03 ->
p5-Proc-Wait3-0.04p0
===> p5-Parallel-Prefork-0.17 depends on: p5-Scope-Guard-* ->
p5-Scope-Guard-0.20p0
===> p5-Parallel-Prefork-0.17 depends on: p5-Signal-Mask-* ->
p5-Signal-Mask-0.008
===> p5-Parallel-Prefork-0.17 depends on: p5-Parallel-Scoreboard-* ->
p5-Parallel-Scoreboard-0.05
===> p5-Parallel-Prefork-0.17 depends on: p5-Test-Requires-* ->
p5-Test-Requires-0.06
===> p5-Parallel-Prefork-0.17 depends on: p5-Test-SharedFork-* ->
p5-Test-SharedFork-0.21
===> p5-Parallel-Prefork-0.17 depends on: Module-Install-* ->
Module-Install-0.01
===> Extracting for p5-Parallel-Prefork-0.17
===> Patching for p5-Parallel-Prefork-0.17
===> Configuring for p5-Parallel-Prefork-0.17
include
/usr/ports/pobj/p5-Parallel-Prefork-0.17/Parallel-Prefork-0.17/inc/Module/Install.pm
include inc/Module/Install/Metadata.pm
include inc/Module/Install/Base.pm
include inc/Module/Install/Makefile.pm
include inc/Module/Install/ReadmeFromPod.pm
readme_from lib/Parallel/Prefork.pm to txt
include inc/Module/Install/WriteAll.pm
include inc/Module/Install/Win32.pm
include inc/Module/Install/Can.pm
include inc/Module/Install/Fetch.pm
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Parallel::Prefork
Writing MYMETA.yml and MYMETA.json
Writing META.yml
===> Building for p5-Parallel-Prefork-0.17
cp lib/Parallel/Prefork.pm blib/lib/Parallel/Prefork.pm
cp lib/Parallel/Prefork/SpareWorkers.pm
blib/lib/Parallel/Prefork/SpareWorkers.pm
cp lib/Parallel/Prefork/SpareWorkers/Scoreboard.pm
blib/lib/Parallel/Prefork/SpareWorkers/Scoreboard.pm
Manifying blib/man3/Parallel::Prefork.3p
Manifying blib/man3/Parallel::Prefork::SpareWorkers.3p
===> Regression tests for p5-Parallel-Prefork-0.17
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib',
'blib/arch')" t/*.t
t/01-base.t ............... ok
t/02-reconfigure.t ........ ok
t/03-spareworkers.t ....... ok
t/04-interval.t ........... ok
t/05-before_after_fork.t .. ok
All tests successful.
Files=5, Tests=24, 20 wallclock secs ( 0.03 usr 0.04 sys + 0.26 cusr 0.53
csys = 0.86 CPU)
Result: PASS
p5-Parallel-Scoreboard.tgz
Description: application/compressed-tar
