Anthony J. Bentley said:
> Doesn't build on amd64.

This is the only platform where I've built it.

> audio/decode/ad_mpg123.o(.text+0x10f): In function `decode_packet':
> audio/decode/ad_mpg123.c:241: undefined reference to `mpg123_decode_frame_64'

I forgot to disable mpg123 support.  I tested this port on a system
where mpg123 was not installed, and I intentionally didn't set
dependency on it.

> # pkg-config says smbclient's version is 0
> CONFIGURE_ARGS +=       --enable-smb \
>                         --extra-libs="-lsmbclient"
>
> Is this something that should be fixed in upstream mpv? It doesn't seem
> to be a bug in our pkg-config, because FDO pkg-config behaves the same.

On OpenBSD -current (#735 amd64):

 $ pkg-config --modversion smbclient
 0

On Archlinux box:

 $ pkg-config --modversion smbclient
 0.2.1

I guess it is our samba package.

> In DESCR, I would remove the "actively developed" bullet. By nature those
> kinds of statements tend to go out of date. And maybe reformat DESCR to
> take up less vertical space, but that's a nitpick.

Done.

-- 
Dmitrij D. Czarkoff

Attachment: mpv.tgz
Description: application/tar-gz

Reply via email to