Hi Rodrigo, thanks for your submission. Rodrigo Mosconi <open...@mosconi.mat.br> writes:
> Follow a new port net/czmq. It is a high-level C bindings for zeromq. > > The port is for version 2.2 of czmq. When the new version (3.0) will be > released, I will update it. > > Is this OK? Not quite. - please respect the order defined in /usr/ports/infrastructure/templates/Makefile.template - for an initial import, or an update to a newer upstream version, REVISION should not be present. - shared libs are an important subject, see the porter's handbook (http://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs) Here the concern is that you shouldn't use upstream library versioning, but maintain your own versioning in parallel, inside the ports tree. So the version should start at 0.0. - the customary way to set WANTLIB is just to copy/paste the output of "make port-lib-depends-check". CONFIGURE_ARGS are usually split on several lines, one per argument. Watch out for trailing whitespace. COMMENT should not start with a capital letter. - it sounds weird to depend on settings added by --with-libzmq=${LOCALBASE} when other libraries (eg. libsodium) should also get picked up from there. In this case I suggest using CONFIGURE_ENV to ensure that CPPFLAGS and LDFLAGS are sane from the start. - libuuid from e2fsprogs, asciidoc and xmlto could be picked up in bulk builds. Either enable (*_DEPENDS) or disable them (see updated tarball). Note that there is fallback code for uuid generation but it isn't quite as optimal as what we have in libc. A nice proposal for upstream would be to use uuid functions from libc (present on most recent *BSD systems). http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/uuid.3 Regarding the packaged files, now: - I think makecert should be renamed as czmq_makecert, at least to avoid a conflict with mono. - wtf are those "gsl" scripts doing in bin/? :) Shouldn't they go to /usr/local/share/czmq... instead? https://github.com/imatix/gsl - I'm wondering whether czmq_selftest should be present Updated tarball, to be unpacked from mystuff/net.
czmq.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
