On Tue, Dec 16, 2014 at 12:49 AM, Jérémie Courrèges-Anglas
<[email protected]> wrote:
> viq <[email protected]> writes:
>
>> Here's a port of py-asn1-modules, looked a bit at FreeBSD's one when
>> making it. Provides some additional functions for working with
>> certificates, sleekxmpp seems to want it to be able to verify certs.
>
> Looks fine, two nits:
>
>> pre-configure:
>> perl -pi -e 's,/usr/bin/python,${MODPY_BIN},g' ${WRKSRC}/tools/*.py
>
> Please use
>
> MODPY_ADJ_FILES = tools/*.py
Ah, I didn't know that existed, thanks.
>> post-install:
>> ${INSTALL_SCRIPT} ${WRKSRC}/tools/* ${PREFIX}/bin
>
> Are those mature enough for ${PREFIX}/bin? If you use them then I have
> no objection, but... upstream doesn't ship them in the default install.
I have no idea. I will retest whether py-sleekxmpp works without them.
I know FreeBSD ships them.
Though on this, another question: the tests in this are a bunch of
shell scripts, that I would need to run "by hand" from our Makefile,
and they do require the mentioned above tools. Should I try and run
them, or should I set NO_TEST?
--
viq
