On Mon, Nov 24, 2014 at 09:24:23PM +0000, Edd Barrett wrote: > Hey, > > Zathura core 0.3.2. Needs the girara update I just posted. > > This started out with me trying to fix the crash in the search feature in > the in-tree version. When I found the crash in 0.3.2, I had to dig deeper. > > In short, in shortcuts.c:sc_search() triggers the stack protector when > it returns. I narrowed the stack trashing down to this line: > > g_object_get(cur_page_widget, "draw-search-results", &draw, NULL); > > I figured this out by doing a binary chop, inserting return statements until I > found the trouble line. > > Valgrind does not detect this on linux. Malloc flags makes no difference, > nor does building -O0. Building zathura with egcc *does* fix the problem, so > I guess this is a bug in the base compiler stack protector(?). > > Anyway, in the following diff I unconditionally build zathura with egcc. > We could decide to do so on only a subset of arches. Thoughts? I have > only tried this on amd64...
This is really a big hammer, and awkward. I'm ok with the girara/zathura update itself, but not with the move to gcc4. Can we make this two separate things ? If our base gcc stack protector has a bug, better find someone who understands it to have a look at it ? Landry
