On Wed, Nov 5, 2014 at 4:25 AM, Stuart Henderson <st...@openbsd.org> wrote:
> On 2014/11/05 03:35, Mike Burns wrote:
> > On 2014-11-03 02.27.11 +0100, Mike Burns wrote:
> > > My first OpenBSD port, so please triple-check it.
> >
> > Update based on feedback off-list.
> >
> > - Patch to support the ruby21 filename (submitted and merged upstream
> > but no new version is released yet).
> > - Re-order the Makefile based on the template.
> >
> > -Mike
>
> ... share/gitsh/gems/blankslate-${MODRUBY_LIBREV}.2.4/
>
> that ${MODRUBY_LIBREV} substitution looks bogus to me, it should probably
> be 2.1.2.4. But shouldn't these install under ${PREFIX}/${GEM_LIB} rather
> than under share/gitsh? I would like a porter familiar with ruby to cast
> an eye over this before it goes in :)
>
>
sthen@ is right, the ${MODRUBY_LIBREV}.2.4 should be manually converted to
2.1.2.4, otherwise it will probably break when the default ruby version
switches to 2.2.
This embeds the blankslate and parslet gems, instead of adding them as
dependencies. However, I don't consider that a problem.
The configure patch is wrong, as it will pick up ruby 2.0 as the version of
ruby to use if it is installed, instead of ruby 2.1. You should force it
to use the default version of ruby used in ports, by adding:
CONFIGURE_ENV = RUBY="${RUBY}"
With the CONFIGURE_ENV addition and PLIST fixes, OK jeremy@ for whoever
wants to import it.
Thanks,
Jeremy
