> From owner-ports+m69...@openbsd.org Sun Oct 26 00:20:08 2014
> From: Stuart Henderson <st...@openbsd.org>
> To: Sunil Nimmagadda <su...@nimmagadda.net>
> Cc: ports@openbsd.org
> Subject: Re: New x11/compton
>
>
> --/04w6evG8XlLl3ft
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
>
> On 2014/10/25 23:57, Sunil Nimmagadda wrote:
> > Hi,
> > 
> > Following a conversation on tech@, here is my attempt at porting
> > compton.
> > 
> > Compton is a compositor for X and is a fork of xcompmgr with bugs
> > fixes and enchancements.
> > 
> > Link to port: https://poolp.org/~sunil/compton.tar.gz
> > 
> > I tested it only on amd64.
> > 
> > Any comments/feedback?
> > 
>
> Thank you! Here are a couple of tweaks.. (diff for ease of comparison below,
> new tgz attached).
>
> - add rcs id
> - use our normal COMMENT style
> - use a version number that pkg_add -u can recognise (no _)
> - regen WANTLIB
> - remove some bogus BUILD_DEPENDS (either LIB_DEPENDS or BUILD_DEPENDS, not 
> both)
> - fork of xcompmgr -> MIT license
> - install .desktop file
> - flesh out DESCR
>

Thank you for the feedback.

> I haven't reviewed the patches yet but it works for me.

I forgot to leave a comment in patches, here they are...

src/c2.{c,h}: base gcc version doesn't support unnamed fields so
given a name to the union.

Makefile: librt removal.

src/common.h: typecast to suppress warnings.

src/compton.{c,h}: default clause to switch statements to suppress warnings.

Reply via email to