On 2014/09/25 11:49, Dmitrij D. Czarkoff wrote:
> Stuart Henderson said:
> > This breaks linking in a normal build. I'll go back to your previous tgz.
> 
> Interesting.  Could you please send me a log?  For me linking does not
> break.

Sorry, I didn't keep it, and have limited time at the moment so
I'll concentrate on the previous one - it's probably due to the
s/MAKE_FLAGS/MAKE_ENV/ for LIBS affecting libre.so.

New tgz attached, builds and works for me (tested SIP calls).
Any OKs to import this?

...

Changes to yours:

| -# BSD
| +# Code is BSD-licensed, but zrtp.so module is statically linked to AGPLv3-
| +# licensed libzrtp.  As a result, main baresip package is subject to AGPLv3.

- need to draw attention to this horrible license.
Maybe worth considering moving this to a subpackage (after import).


| -MAKE_FLAGS +=                LD=${CC}
| +MAKE_FLAGS +=                CC="${CC}"
| +MAKE_FLAGS +=                LD="${CC}"

- honour CC.

|  DISTNAME =   baresip-0.4.11
|  
| -WANTLIB  =   X11 Xext avcodec avdevice avformat avutil c crypto gsm
| +WANTLIB +=   X11 Xext avcodec avdevice avformat avutil c crypto gsm

- ports standard

| -LIB_DEPENDS =        audio/gsm audio/libsndfile audio/opus audio/speex \
| -             graphics/ffmpeg multimedia/libvpx sysutils/e2fsprogs \
| -             telephony/baresip/rem telephony/spandsp
| +LIB_DEPENDS =        audio/gsm \
| +             audio/libsndfile \
[..]

- ports standard

Various patches added like this:
| + $(SHARED): $(APP_OBJS)
| +-    @echo "  LD      $@"
| +-    @$(LD) $(LFLAGS) $(SH_LFLAGS) $^ -L$(LIBRE_SO) -lre $(LIBS) -o $@
| ++    $(LD) $(LFLAGS) $(SH_LFLAGS) $^ -L$(LIBRE_SO) -lre $(LIBS) -o $@

etc. - ports standard is to not hide compiler/linker command lines

| diff --git a/restund/pkg/PLIST b/restund/pkg/PLIST
| index 7a511b5..8c90a69 100644
| --- a/restund/pkg/PLIST
| +++ b/restund/pkg/PLIST
| @@ -19,5 +19,6 @@ share/examples/restund/munin/
|  share/examples/restund/munin/restund
|  share/examples/restund/munin/restund_turn_allocs
|  share/examples/restund/munin/restund_turn_bytes
| -@sample ${SYSCONFDIR}/restund.conf
|  share/examples/restund/restund.conf
| +@sample ${SYSCONFDIR}/restund.conf
| +@rcscript ${RCDIR}/restund

- rcscript missing from PLIST
- wrong file @sample'd

(I've also added the uid to db/user.list).

Attachment: baresip.tgz
Description: application/tar-gz

Reply via email to