Hi Remi, thanks for the feedback. I messed up the spaces, so all diffs are ready for /dev/null. I'll post clean ones in the next few hours to ports@.
Regarding the failed 'user_agent_online.t' test...this also happens when running 'make test' against 4.99, so it looks like this has never worked before...? Anyway, i'll dig into this and come back to you soon. On Tue, Sep 02, 2014 at 10:28:58PM +0200, Remi Locherer wrote: > Hi Mark > > On Sun, Aug 31, 2014 at 07:33:57PM +0200, Mark Patruck wrote: > > Finally update www/p5-Mojo to 5.35. The patch regarding IO::Socket::SSL > > can be removed as fixed upstream. > > I think the maintainer line can be removed from the Makefile. I didn't > see action from Simon regarding Mojo in the lasti couple of years. > > How did you generate this and the preceding patches? The p5-Mojo patch > and also the p5-common-sense patch did not apply cleanly with > "patch -p0 > /path/to/patch" on my fresh checkout. > > I patched it manually and ran "make test". 6 user_agent_online subtests > failed (see below). But this might be because I did not yet update the > 4 related ports you send patches for. > > Mojo::Reactor::Poll: Read failed: Can't call method "on" on an undefined > value at > /usr/ports/pobj/p5-Mojolicious-5.35/Mojolicious-5.35/blib/lib/Mojo/UserAgent.pm > line 123. > > # Failed test 'transaction is finished' > # at t/mojo/user_agent_online.t line 71. > > # Failed test 'has error' > # at t/mojo/user_agent_online.t line 72. > Mojo::Reactor::Poll: Read failed: Can't call method "on" on an undefined > value at > /usr/ports/pobj/p5-Mojolicious-5.35/Mojolicious-5.35/blib/lib/Mojo/UserAgent.pm > line 123. > > # Failed test 'transaction is finished' > # at t/mojo/user_agent_online.t line 77. > > # Failed test 'has error' > # at t/mojo/user_agent_online.t line 78. > Mojo::Reactor::Poll: Read failed: Can't call method "on" on an undefined > value at > /usr/ports/pobj/p5-Mojolicious-5.35/Mojolicious-5.35/blib/lib/Mojo/UserAgent.pm > line 123. > > # Failed test 'transaction is finished' > # at t/mojo/user_agent_online.t line 83. > > # Failed test 'has error' > # at t/mojo/user_agent_online.t line 84. > # Looks like you failed 6 tests of 91. > t/mojo/user_agent_online.t ................. > Dubious, test returned 6 (wstat 1536, 0x600) > Failed 6/91 subtests > > > I try to find the time to look at all the patches you sent in the next > days. > > Remi -- Mark Patruck ( mark at wrapped.cx ) GPG key 0xF2865E51 / 187F F6D3 EE04 1DCE 1C74 F644 0D3C F66F F286 5E51 http://www.wrapped.cx
