On 2014-08-18, Brad Smith <b...@comstyle.com> wrote:

> Here is a diff to enable the uTP support with Transmission. It looks
> like the unaligned accesses issues were fixed a tad under 2 years ago.

What makes you think so?  The only relevant difference between 2.30
and 2.84 is that structs are now individually marked as packed too,
but that should be a nop because the whole section is bracketed by
#pragma pack anyway.

The problem is that the seq_nr and ack_nr fields in PacketFormat
(in utp.cpp) are misaligned.  I don't quite know under what
circumstances gcc should handle direct loads/stores of these fields,
but in practice where pointers to different structs are cast back
and forth and eventually dereferenced, this blows up.

> Any Transmission users able to test especially on say sparc64?

Yes, but the code hasn't changed.

-- 
Christian "naddy" Weisgerber                          na...@mips.inka.de

Reply via email to