2014-07-14 23:31 GMT+02:00 Daniel Dickman <[email protected]>: > On Mon, Jul 14, 2014 at 5:19 PM, Vadim Zhukov <[email protected]> wrote: >> 2014-07-14 21:48 GMT+02:00 Vadim Zhukov <[email protected]>: >>> 2014-07-14 21:41 GMT+02:00 Rafael Sadowski <[email protected]>: >>>> hey @ports, >>>> >>>> Update to latest R, all regress pass, Ok? >>> >>> Testing it now, thanks. >>> >>> For those who are curious, here is a changelog: >>> https://stat.ethz.ch/pipermail/r-announce/2014/000575.html >> >> Please, add the attached patch and push it upstream (feel free to >> modify it if necessary). It fixes real problems and somewhat assures >> against similar future errors. The issue was catched by looking at the >> compiler warnings, thanks to the -Wbounded check. > > Is your patch correct? I haven't looked at the more of the context, > but have you changed January to have 30 days in a non-leap year? not > sure about that one.
Ouch, you're write. I was trying to understand what's those are (yes, I was stupid enough to about those numbers as years initially) and forgot to backout then. Thank you for spotting this! Updated patch is attached. -- WBR, Vadim Zhukov
patch-src_main_Rstrptime_h
Description: Binary data
